From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: Shmulik Ladkani <shmulik.ladkani@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Heinz.Egger@linutronix.de, tim.bird@am.sony.com,
tglx@linutronix.de
Subject: Re: [PATCH] [RFC] UBI: Implement Fastmap support
Date: Thu, 24 May 2012 12:21:39 +0300 [thread overview]
Message-ID: <1337851299.15137.96.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <4FBDF0CB.4040501@nod.at>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On Thu, 2012-05-24 at 10:26 +0200, Richard Weinberger wrote:
> On 24.05.2012 10:19, Artem Bityutskiy wrote:
> >> After thinking a bit more about this case I think the best we can to
> >> is
> >> switching to read-only mode if ubi_update_fastmap()
> >> fails.
> >>
> > Unless it fails because of -EIO, which means the PEB may become bad and
> > you need to pick a different one and schedule the faulty one for
> > torturing and marking as bad.
>
> Wouldn't make more sense if ubi_update_fastmap() handles the -EIO case
> internally?
Probably, I just meant that at the end the faulty PEB should end up
being scheduled for erasure and torturing like all other places do it.
We should preferably have one code path which marks PEBs as bad. It is
much easier than to make changes there.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-24 9:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 14:01 [RFC v6] UBI: Fastmap support (aka checkpointing) Richard Weinberger
2012-05-21 14:01 ` [PATCH] [RFC] UBI: Implement Fastmap support Richard Weinberger
2012-05-22 13:43 ` Artem Bityutskiy
2012-05-22 15:01 ` Shmulik Ladkani
2012-05-22 16:55 ` Richard Weinberger
2012-05-22 18:18 ` Shmulik Ladkani
2012-05-22 18:57 ` Richard Weinberger
2012-05-23 6:18 ` Shmulik Ladkani
2012-05-23 7:43 ` Richard Weinberger
2012-05-22 20:11 ` Richard Weinberger
2012-05-24 8:19 ` Artem Bityutskiy
2012-05-24 8:26 ` Richard Weinberger
2012-05-24 9:21 ` Artem Bityutskiy [this message]
2012-05-24 8:17 ` Artem Bityutskiy
2012-05-24 9:56 ` Shmulik Ladkani
2012-05-24 10:03 ` Richard Weinberger
2012-05-24 20:07 ` Shmulik Ladkani
2012-05-24 8:22 ` Artem Bityutskiy
2012-05-24 8:24 ` Richard Weinberger
-- strict thread matches above, loose matches on Subject: below --
2012-05-23 11:06 [RFC v7] UBI: Fastmap support (aka checkpointing) Richard Weinberger
2012-05-23 11:06 ` [PATCH] [RFC] UBI: Implement Fastmap support Richard Weinberger
2012-05-26 13:22 ` Artem Bityutskiy
2012-05-31 10:37 ` Adrian Hunter
2012-05-31 13:31 ` Richard Weinberger
2012-06-01 5:47 ` Adrian Hunter
2012-06-01 8:00 ` Richard Weinberger
2012-06-01 8:10 ` Artem Bityutskiy
2012-06-01 8:10 ` Richard Weinberger
2012-06-01 8:47 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337851299.15137.96.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=Heinz.Egger@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=shmulik.ladkani@gmail.com \
--cc=tglx@linutronix.de \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).