From: Joe Perches <joe@perches.com>
To: Kevin McKinney <klmckinney1@gmail.com>
Cc: Devendra Naga <devendra.aaru@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [staging] bcm: Fix codingstyle problems
Date: Sun, 27 May 2012 19:38:54 -0700 [thread overview]
Message-ID: <1338172734.977.3.camel@joe2Laptop> (raw)
In-Reply-To: <CAKPrQY8O0=PQroL6vYOCATG3WUx1ChgqW9rFqhuY2G7Q7oj3WA@mail.gmail.com>
On Sun, 2012-05-27 at 22:30 -0400, Kevin McKinney wrote:
> Hi Devendra,
>
> On Sun, May 27, 2012 at 4:54 PM, Devendra Naga <devendra.aaru@gmail.com> wrote:
> > Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
> > ---
> > drivers/staging/bcm/Debug.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> I understand this is a simple change, but please add a descriptive
> change log to your patch for consistency.
Hello as well.
Devendra, sometimes the simpler change isn't the best change.
Consider converting some of these macros into functions.
next prev parent reply other threads:[~2012-05-28 2:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 20:54 [PATCH] [staging] bcm: Fix codingstyle problems Devendra Naga
2012-05-28 2:30 ` Kevin McKinney
2012-05-28 2:38 ` Joe Perches [this message]
2012-05-28 4:23 ` devendra.aaru
2012-05-28 4:37 ` Joe Perches
2012-05-28 7:22 ` devendra.aaru
2012-05-28 9:34 ` Dan Carpenter
2012-05-28 15:02 ` Joe Perches
2012-05-28 20:58 ` Kevin McKinney
2012-05-28 4:17 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338172734.977.3.camel@joe2Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=devendra.aaru@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=klmckinney1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).