public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dave Jones <davej@redhat.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>,
	Dave Airlie <airlied@redhat.com>,
	Rob Clark <rob.clark@linaro.org>
Subject: Re: Lots of i915/drm spew on 3.4
Date: Thu, 31 May 2012 08:59:57 +0100	[thread overview]
Message-ID: <1338451231_375838@CP5-2952> (raw)
In-Reply-To: <20120530222651.GA22449@redhat.com>

On Wed, 30 May 2012 18:26:51 -0400, Dave Jones <davej@redhat.com> wrote:
> On Wed, May 30, 2012 at 05:58:48PM -0400, Dave Jones wrote:
>  > On Wed, May 30, 2012 at 11:51:54PM +0200, Daniel Vetter wrote:
>  >  > On Wed, May 30, 2012 at 11:31 PM, Dave Jones <davej@redhat.com> wrote:
>  >  > > On this hardware:
>  >  > >
>  >  > > 00:02.0 VGA compatible controller: Intel Corporation 82945G/GZ Integrated Graphics Controller (rev 02)
>  >  > >
>  >  > > I get this every boot with Linus current tree (up to af56e0aa35f3ae2a4c1a6d1000702df1dd78cb76)
>  >  > 
>  >  > Just a quick question, is this a regression? 
>  > 
>  > seems so, I don't see it on 3.3

The WARN is new, the problem is old.

commit c543188afb7a83e66161c026dc6fd5eb38dc0b63
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date:   Tue May 15 18:09:02 2012 -0300

    drm: add generic ioctls to get/set properties on any object
    
    Useless for connector properties (since they already have their own
    ioctls), but useful when we add properties to CRTCs, planes and other
    objects.
    
    Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
    Reviewed-by: Rob Clark <rob.clark@linaro.org>
    Tested-by: Rob Clark <rob.clark@linaro.org>
    Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>

Before that commit we had no idea that we had run out of property slots.
I think the WARN is genuine, but maybe we should just bump the count set
it to WARN_ONCE and hope the conversion to lists arrives sooner rather
than latter.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2012-05-31  8:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30 21:31 Lots of i915/drm spew on 3.4 Dave Jones
2012-05-30 21:51 ` Daniel Vetter
2012-05-30 21:58   ` Dave Jones
2012-05-30 22:26     ` Dave Jones
2012-05-31  7:59       ` Chris Wilson [this message]
2012-05-31 13:22         ` Paulo Zanoni
2012-06-03 15:17           ` Daniel Vetter
2012-05-31 14:43       ` Paulo Zanoni
2012-06-03 13:27         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338451231_375838@CP5-2952 \
    --to=chris@chris-wilson.co.uk \
    --cc=airlied@redhat.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=davej@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=rob.clark@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox