From: Namhyung Kim <namhyung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Namhyung Kim <namhyung.kim@lge.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Sunjin Yang <fan4326@gmail.com>, Arun Sharma <asharma@fb.com>
Subject: Re: [PATCH/RFC 2/2] perf tools: Check callchain is corrupted
Date: Thu, 31 May 2012 23:04:37 +0900 [thread overview]
Message-ID: <1338473077.1484.8.camel@leonhard> (raw)
In-Reply-To: <20120531134557.GB13591@infradead.org>
Hi,
2012-05-31 (목), 10:45 -0300, Arnaldo Carvalho de Melo:
> Em Thu, May 31, 2012 at 02:43:27PM +0900, Namhyung Kim escreveu:
> > We faced segmentation fault on perf top -G at very high sampling
> > rate due to a corrupted callchain. While the root cause was not
> > revealed (I failed to figure it out), this patch tries to protect
> > us from the segfault on such cases.
>
> Capping the callchain lenght may even be a feature, not a consistency
> check, but I don't know how long, for consistency checking, we should
> consider too much, as there are cases of loooong callchains.
>
Maybe we should consider applying (a part of, at least) Arun's multiple
stack patchset. Also note that Linus complained about the current stack
depth (255) is too long.
https://lkml.org/lkml/2012/4/20/497
--
Regards,
Namhyung Kim
next prev parent reply other threads:[~2012-05-31 14:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 5:43 [PATCH 1/2] perf callchain: Make callchain cursors TLS Namhyung Kim
2012-05-31 5:43 ` [PATCH/RFC 2/2] perf tools: Check callchain is corrupted Namhyung Kim
2012-05-31 13:45 ` Arnaldo Carvalho de Melo
2012-05-31 14:04 ` Namhyung Kim [this message]
2012-05-31 14:31 ` Arnaldo Carvalho de Melo
2012-06-01 17:52 ` Zachary Landau
2012-06-06 7:01 ` [tip:perf/urgent] perf tools: Check if " tip-bot for Namhyung Kim
2012-06-01 17:50 ` [PATCH 1/2] perf callchain: Make callchain cursors TLS Zachary Landau
2012-06-06 7:00 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338473077.1484.8.camel@leonhard \
--to=namhyung@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=asharma@fb.com \
--cc=fan4326@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox