From: Shuah Khan <shuahkhan@gmail.com>
To: Fabio Baltieri <fabio.baltieri@gmail.com>
Cc: shuahkhan@gmail.com, Bryan Wu <bryan.wu@canonical.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH v2 1/3] leds: add oneshot blink functions
Date: Fri, 01 Jun 2012 09:39:40 -0600 [thread overview]
Message-ID: <1338565180.2618.9.camel@lorien2> (raw)
In-Reply-To: <20120531210800.GB2400@gmail.com>
>
> There should be no compatibity issues with current timer-trigger calls,
> can you be more specific?
My initial thought was that maybe you could create new namespace for
this trigger instead of using delay_on and delay_off. However, after
looking closely at the patch set you are proposing, since you are using
delay_on and delay_off in led_cdev, I think you are ok.
Please make sure there is no regression in the ledtrig-timer use-cases,
with the changes made to led-class and led-core.
-- Shuah
next prev parent reply other threads:[~2012-06-01 15:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 23:19 [PATCH v2 1/3] leds: add oneshot blink functions Fabio Baltieri
2012-05-26 23:19 ` [PATCH 2/3] ledtrig-ide-disk: use generic one-shot blink api Fabio Baltieri
2012-06-05 7:20 ` Bryan Wu
2012-05-26 23:19 ` [PATCH 3/3] led: add oneshot trigger Fabio Baltieri
2012-05-27 16:09 ` Shuah Khan
2012-05-31 21:01 ` Fabio Baltieri
2012-06-05 7:37 ` Bryan Wu
2012-06-05 20:55 ` Fabio Baltieri
2012-05-27 16:13 ` [PATCH v2 1/3] leds: add oneshot blink functions Shuah Khan
2012-05-31 21:08 ` Fabio Baltieri
2012-06-01 15:39 ` Shuah Khan [this message]
2012-06-04 21:37 ` Fabio Baltieri
2012-06-04 23:12 ` Shuah Khan
2012-06-05 3:05 ` Bryan Wu
2012-06-05 14:59 ` Shuah Khan
2012-06-06 2:44 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338565180.2618.9.camel@lorien2 \
--to=shuahkhan@gmail.com \
--cc=bryan.wu@canonical.com \
--cc=fabio.baltieri@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).