* [PATCH] regulator: twl: Convert twl6030ldo_ops to use regulator_list_voltage_linear
@ 2012-06-04 4:44 Axel Lin
2012-06-11 3:40 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-06-04 4:44 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Ujfalusi, Rajendra Nayak, Tero Kristo, Liam Girdwood,
Mark Brown
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/twl-regulator.c | 13 +++++--------
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index c739071..a1d07e5 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -577,13 +577,6 @@ static struct regulator_ops twl6030coresmps_ops = {
.get_voltage = twl6030coresmps_get_voltage,
};
-static int twl6030ldo_list_voltage(struct regulator_dev *rdev, unsigned index)
-{
- struct twlreg_info *info = rdev_get_drvdata(rdev);
-
- return ((info->min_mV + (index * 100)) * 1000);
-}
-
static int
twl6030ldo_set_voltage(struct regulator_dev *rdev, int min_uV, int max_uV,
unsigned *selector)
@@ -621,7 +614,7 @@ static int twl6030ldo_get_voltage(struct regulator_dev *rdev)
}
static struct regulator_ops twl6030ldo_ops = {
- .list_voltage = twl6030ldo_list_voltage,
+ .list_voltage = regulator_list_voltage_linear,
.set_voltage = twl6030ldo_set_voltage,
.get_voltage = twl6030ldo_get_voltage,
@@ -959,6 +952,8 @@ static struct twlreg_info TWL6030_INFO_##label = { \
.ops = &twl6030ldo_ops, \
.type = REGULATOR_VOLTAGE, \
.owner = THIS_MODULE, \
+ .min_uV = min_mVolts * 1000, \
+ .uV_step = 100 * 1000, \
}, \
}
@@ -974,6 +969,8 @@ static struct twlreg_info TWL6025_INFO_##label = { \
.ops = &twl6030ldo_ops, \
.type = REGULATOR_VOLTAGE, \
.owner = THIS_MODULE, \
+ .min_uV = min_mVolts * 1000, \
+ .uV_step = 100 * 1000, \
}, \
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: twl: Convert twl6030ldo_ops to use regulator_list_voltage_linear
2012-06-04 4:44 [PATCH] regulator: twl: Convert twl6030ldo_ops to use regulator_list_voltage_linear Axel Lin
@ 2012-06-11 3:40 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-06-11 3:40 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Peter Ujfalusi, Rajendra Nayak, Tero Kristo,
Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 123 bytes --]
On Mon, Jun 04, 2012 at 12:44:15PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-11 3:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-04 4:44 [PATCH] regulator: twl: Convert twl6030ldo_ops to use regulator_list_voltage_linear Axel Lin
2012-06-11 3:40 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).