From: Tao Guo <glorioustao@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Tao Guo <glorioustao@gmail.com>, Tao Guo <Tao.Guo@emc.com>,
Neil Brown <neilb@suse.de>, Jens Axboe <axboe@kernel.dk>,
<stable@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 2/2] umem: fix up unplugging
Date: Mon, 4 Jun 2012 10:41:51 -0400 [thread overview]
Message-ID: <1338820911-4733-2-git-send-email-glorioustao@gmail.com> (raw)
In-Reply-To: <1338820911-4733-1-git-send-email-glorioustao@gmail.com>
In that patch, Jens removed the whole mm_unplug_device()
function, which used to be the trigger to make umem start to work.
We need to implement unplugging to make umem start to work, or I/O
will never be triggered.
Signed-off-by: Tao Guo <Tao.Guo@emc.com>
Cc: Neil Brown <neilb@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: <stable@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: <stable@vger.kernel.org>
---
drivers/block/umem.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/block/umem.c b/drivers/block/umem.c
index aa27120..89cc9a6 100644
--- a/drivers/block/umem.c
+++ b/drivers/block/umem.c
@@ -513,6 +513,15 @@ static void process_page(unsigned long data)
}
}
+static void mm_unplug(struct blk_plug_cb *cb)
+{
+ struct cardinfo *card = cb->q->queuedata;
+
+ spin_lock_irq(&card->lock);
+ activate(card);
+ spin_unlock_irq(&card->lock);
+}
+
static void mm_make_request(struct request_queue *q, struct bio *bio)
{
struct cardinfo *card = q->queuedata;
@@ -523,6 +532,8 @@ static void mm_make_request(struct request_queue *q, struct bio *bio)
*card->biotail = bio;
bio->bi_next = NULL;
card->biotail = &bio->bi_next;
+ if (bio->bi_rw & REQ_SYNC || !blk_check_plugged(q, mm_unplug))
+ activate(card);
spin_unlock_irq(&card->lock);
return;
--
1.7.7.6
next prev parent reply other threads:[~2012-06-04 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 14:41 [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core Tao Guo
2012-06-04 14:41 ` Tao Guo [this message]
2012-06-04 14:49 ` [PATCH 2/2] umem: fix up unplugging Tao Guo
2012-06-05 1:21 ` [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core Shaohua Li
2012-06-05 1:48 ` Tao.Guo
2012-06-06 2:07 ` Shaohua Li
2012-06-07 17:06 ` Tao.Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338820911-4733-2-git-send-email-glorioustao@gmail.com \
--to=glorioustao@gmail.com \
--cc=Tao.Guo@emc.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).