From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Arun Sharma <asharma@fb.com>
Cc: Andrew Vagin <avagin@openvz.org>,
Oleg Strikov <OSTRIKOV@nvidia.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH 0/5] Teach perf tool to profile sleep times (V4)
Date: Mon, 04 Jun 2012 22:52:14 +0200 [thread overview]
Message-ID: <1338843134.28282.145.camel@twins> (raw)
In-Reply-To: <4FCCE9F5.9050808@fb.com>
On Mon, 2012-06-04 at 10:01 -0700, Arun Sharma wrote:
> On 6/4/12 5:40 AM, Peter Zijlstra wrote:
>
> > And as a result you need that hideous prev_state crap.
> >
> >
> > Would something like the below work?
> >
> > The one thing I'm not entirely sure of is if this is a sekjoerity issue
> > or not.. anybody? I would think a task was entitled to know who woke it
> > and wherefrom etc..
>
> Frederic had some comments on this topic in the last round:
>
> http://thread.gmane.org/gmane.linux.kernel/1195368/focus=1195959
>
> > We should probably avoid the remote callchains, sounds like asking
> for complications everywhere.
>
> Do they still apply? Frederic?
Probably, but note that the approaches are slightly different. The
previous thing would wreck the callchain for everybody, the proposed
thing will make more events.
Also, you don't need the callchain on the wakeup side of things. You
only want the callchain of the sched_switch site.
We could even dis-allow the callchain unwind when event->ctx->task &&
event->ctx->task != current -- pretend the unwind failed by writing 0
entries.
That also avoids the 'difficultly' of exposing and trying to interpret
another task's callchain.
next prev parent reply other threads:[~2012-06-04 20:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 8:09 [RFC] [PATCH 0/5] Teach perf tool to profile sleep times (V4) Andrew Vagin
2012-06-04 8:09 ` [PATCH 1/5] sched: event: add trace events when a task starts executing on a cpu Andrew Vagin
2012-06-04 8:09 ` [PATCH 2/5] sched: send the event sched_switch before perf_event_task_sched_out Andrew Vagin
2012-06-04 8:09 ` [PATCH 3/5] sched: save a previous state on task_struct Andrew Vagin
2012-06-04 8:09 ` [PATCH 4/5] perf: teach "perf inject" to work with files Andrew Vagin
2012-06-04 8:09 ` [PATCH 5/5] perf: teach perf inject to merge sched_switch* events for profiling sleep times Andrew Vagin
2012-06-04 12:40 ` [RFC] [PATCH 0/5] Teach perf tool to profile sleep times (V4) Peter Zijlstra
2012-06-04 12:50 ` Peter Zijlstra
2012-06-04 13:46 ` Steven Rostedt
2012-06-04 17:01 ` Arun Sharma
2012-06-04 20:52 ` Peter Zijlstra [this message]
2012-06-06 8:32 ` Ingo Molnar
2012-06-12 13:15 ` Andrew Wagin
2012-06-12 17:46 ` Peter Zijlstra
2012-06-04 17:03 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338843134.28282.145.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=OSTRIKOV@nvidia.com \
--cc=asharma@fb.com \
--cc=avagin@openvz.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).