From: Stefani Seibold <stefani@seibold.net>
To: Oliver Neukum <oneukum@suse.de>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] fix usb skeleton driver
Date: Wed, 06 Jun 2012 09:46:06 +0200 [thread overview]
Message-ID: <1338968766.4143.6.camel@wall-e> (raw)
In-Reply-To: <201206060929.02676.oneukum@suse.de>
Am Mittwoch, den 06.06.2012, 09:29 +0200 schrieb Oliver Neukum:
> Am Mittwoch, 6. Juni 2012, 09:00:36 schrieb stefani@seibold.net:
> > From: Stefani Seibold <stefani@seibold.net>
> >
> > This is a fix for the USB skeleton driver to bring it in shape.
> >
> > - The usb_device structure pointer will no longer stored
> > - Every access to the USB will be handled trought the usb_interface pointer
> > - No longer assign a NULL to usb_interface pointer in the disconnect() handler
>
> Why? What is gained?
>
All of this topics was suggested by Greg.
If a NULL is assigned to the usb_interface pointer, the skel_delete
cannot do an usb_put_dev() since the usb_device pointer is no longer
available.
Greetings
next prev parent reply other threads:[~2012-06-06 7:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 7:00 [PATCH] fix usb skeleton driver stefani
2012-06-06 7:29 ` Oliver Neukum
2012-06-06 7:46 ` Stefani Seibold [this message]
2012-06-06 7:44 ` Oliver Neukum
2012-06-06 7:32 ` Oliver Neukum
2012-06-06 12:18 ` Stefani Seibold
2012-06-06 8:11 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-06-06 13:23 stefani
2012-06-06 13:50 ` Oliver Neukum
2012-06-06 14:28 ` Ming Lei
2012-06-06 15:05 ` Stefani Seibold
2012-06-07 1:05 ` Ming Lei
2012-06-06 15:06 ` Alan Stern
2012-06-06 18:37 ` Oliver Neukum
2012-06-06 16:27 stefani
2012-06-06 16:55 ` Alan Stern
2012-06-06 17:53 ` Stefani Seibold
2012-06-06 18:16 ` Alan Stern
2012-06-06 20:19 ` Stefani Seibold
2012-06-06 20:22 ` Alan Stern
2012-06-07 8:13 ` Stefani Seibold
2012-06-07 7:10 ` Bjørn Mork
2012-06-07 8:20 stefani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338968766.4143.6.camel@wall-e \
--to=stefani@seibold.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox