From: Artem Bityutskiy <dedekind1@gmail.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>,
"Pawel Moll" <pawel.moll@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: init: multi param parsing regression since 3.4
Date: Wed, 06 Jun 2012 11:28:23 +0300 [thread overview]
Message-ID: <1338971303.6875.6.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <87ipf71ytx.fsf@rustcorp.com.au>
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
On Mon, 2012-06-04 at 14:02 +0930, Rusty Russell wrote:
> + printk("ubi_mtd_param_parse: val = %s\n", val);
> + WARN_ON(1);
> if (!val)
> return -EINVAL;
Hi, please, zap this printk() and WARN_ON().
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-06-06 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1002174455.1843950.1338570468781.JavaMail.root@advansee.com>
2012-06-01 17:26 ` init: multi param parsing regression since 3.4 Benoît Thébaudeau
2012-06-02 15:50 ` Benoît Thébaudeau
2012-06-04 4:32 ` Rusty Russell
2012-06-04 12:38 ` Benoît Thébaudeau
2012-06-04 20:39 ` Linus Torvalds
2012-06-05 0:17 ` Rusty Russell
2012-06-05 1:25 ` Linus Torvalds
2012-06-06 8:28 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338971303.6875.6.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=benoit.thebaudeau@advansee.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox