Re: [PATCH 3/5] perf, x86: Check LBR format capability

Peter Zijlstra
2012-06-06T14:22:47Z

On Wed, 2012-06-06 at 07:14 -0700, Andi Kleen wrote:
> On Wed, Jun 06, 2012 at 12:40:24PM +0200, Peter Zijlstra wrote:
> > On Tue, 2012-06-05 at 17:56 -0700, Andi Kleen wrote:
> > > From: Andi Kleen <ak@linux.intel.com>
> > >
> > > Double check the CPU has a LBR format we support before using it.
> > >
> > > Also I made the init functions __init while I was on it.
> >
> > Why? Its all after a model test anyway.
>
> Because the spec says we should check it.

The spec says lots of things.. but being that LBR is very much model
specific I really can't be bothered.

> It could catch bad VMs and other inconsistencies and it's the right thing
> to do.

That might be a reason, but does it?, and why wasn't that in the
changelog?