Re: [PATCH] perf/x86: check ucode before disabling PEBS on SandyBridge

Borislav Petkov
2012-06-12T17:34:49Z

On Tue, Jun 12, 2012 at 07:26:36PM +0200, Peter Zijlstra wrote:
> You want, yes, but afaict the stuff in
> arch/x86/kernel/microcode_core.c:reload_store means you can force a
> single cpu to update while leaving the others alone.

Btw, this doesn't work on AMD... for a reason.

> Afaict this is not a sane thing to do, but quite possible.

I'd guess this is still there to support mixed ucode revisions for some
oldish platforms. But if SB doesn't support mixed ucode revisions,
you don't want to use the reload_store interface anyway for reasons
described above. Maybe this interface should be behind a family, model
check or so, so that users don't shoot themselves in the foot but it is
root-only anyway.

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551