Re: [PATCH 0/2] Move the tpm_get_random api and add an hwrng driver for it

[David Safford <safford@linux.vnet.ibm.com>]

On Thu, 2012-06-07 at 13:42 -0500, Kent Yoder wrote:
> These patches move the tpm_get_random API out of the trusted keys code
> and into the tpm device driver itself.  Then a hwrng driver is added that
> makes use of the API to provide a H/W RNG source.

Very nice! checkpatch complained a bit on patch 1, but otherwise,
Acked-by: David Safford <safford@linux.vnet.ibm.com>

>   These are based off the latest upstream kernel.
> 
> Thanks,
> Kent
> 
> Kent Yoder (2):
>   tpm: Move tpm_get_random api into the TPM device driver
>   hw_random: add support for the TPM chip as a hardware RNG source
> 
>  drivers/char/hw_random/Kconfig   |   13 +++++++++
>  drivers/char/hw_random/Makefile  |    1 +
>  drivers/char/hw_random/tpm-rng.c |   55 ++++++++++++++++++++++++++++++++++++++
>  drivers/char/tpm/tpm.c           |   53 ++++++++++++++++++++++++++++++++----
>  drivers/char/tpm/tpm.h           |   23 ++++++++++++++++
>  include/linux/tpm.h              |    4 +++
>  security/keys/trusted.c          |   47 +++++++-------------------------
>  7 files changed, 153 insertions(+), 43 deletions(-)
>  create mode 100644 drivers/char/hw_random/tpm-rng.c
>