From: Don Zickus <dzickus@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: baryluk@smp.if.uj.edu.pl, LKML <linux-kernel@vger.kernel.org>,
JBeulich@suse.com, zhong@linux.vnet.ibm.com,
Don Zickus <dzickus@redhat.com>
Subject: [PATCH 1/2] Revert "x86/nmi: Fix section mismatch warnings on 32-bit"
Date: Mon, 11 Jun 2012 11:33:28 -0400 [thread overview]
Message-ID: <1339428809-29360-2-git-send-email-dzickus@redhat.com> (raw)
In-Reply-To: <1339428809-29360-1-git-send-email-dzickus@redhat.com>
This reverts commit eeaaa96a3a2134a174100afd129bb0891d05f4b2.
There is a cleaner/simpler way to achieve this.
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
arch/x86/include/asm/nmi.h | 14 --------------
arch/x86/kernel/nmi_selftest.c | 4 ++--
2 files changed, 2 insertions(+), 16 deletions(-)
diff --git a/arch/x86/include/asm/nmi.h b/arch/x86/include/asm/nmi.h
index dc580c4..0e3793b 100644
--- a/arch/x86/include/asm/nmi.h
+++ b/arch/x86/include/asm/nmi.h
@@ -54,20 +54,6 @@ struct nmiaction {
__register_nmi_handler((t), &fn##_na); \
})
-/*
- * For special handlers that register/unregister in the
- * init section only. This should be considered rare.
- */
-#define register_nmi_handler_initonly(t, fn, fg, n) \
-({ \
- static struct nmiaction fn##_na __initdata = { \
- .handler = (fn), \
- .name = (n), \
- .flags = (fg), \
- }; \
- __register_nmi_handler((t), &fn##_na); \
-})
-
int __register_nmi_handler(unsigned int, struct nmiaction *);
void unregister_nmi_handler(unsigned int, const char *);
diff --git a/arch/x86/kernel/nmi_selftest.c b/arch/x86/kernel/nmi_selftest.c
index 149b8d9..e31bf8d 100644
--- a/arch/x86/kernel/nmi_selftest.c
+++ b/arch/x86/kernel/nmi_selftest.c
@@ -42,7 +42,7 @@ static int __init nmi_unk_cb(unsigned int val, struct pt_regs *regs)
static void __init init_nmi_testsuite(void)
{
/* trap all the unknown NMIs we may generate */
- register_nmi_handler_initonly(NMI_UNKNOWN, nmi_unk_cb, 0, "nmi_selftest_unk");
+ register_nmi_handler(NMI_UNKNOWN, nmi_unk_cb, 0, "nmi_selftest_unk");
}
static void __init cleanup_nmi_testsuite(void)
@@ -64,7 +64,7 @@ static void __init test_nmi_ipi(struct cpumask *mask)
{
unsigned long timeout;
- if (register_nmi_handler_initonly(NMI_LOCAL, test_nmi_ipi_callback,
+ if (register_nmi_handler(NMI_LOCAL, test_nmi_ipi_callback,
NMI_FLAG_FIRST, "nmi_selftest")) {
nmi_fail = FAILURE;
return;
--
1.7.7.6
next prev parent reply other threads:[~2012-06-11 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 15:33 [PATCH 0/2] x86,nmi: Section header fixes Don Zickus
2012-06-11 15:33 ` Don Zickus [this message]
2012-06-11 15:33 ` [PATCH 2/2] x86,nmi: Fix section mismatch warnings on 32-bit Don Zickus
2012-06-18 9:07 ` [PATCH 0/2] x86,nmi: Section header fixes Ingo Molnar
2012-06-18 13:33 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339428809-29360-2-git-send-email-dzickus@redhat.com \
--to=dzickus@redhat.com \
--cc=JBeulich@suse.com \
--cc=baryluk@smp.if.uj.edu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox