Re: [PATCH RFT 3/4] regulator: wm831x-dcdc: Convert wm831x_buckv_ops to set_voltage_sel and map_voltage

Mark Brown
2012-06-13T11:51:21Z

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

On Wed, Jun 13, 2012 at 07:41:26PM +0800, Axel Lin wrote:

> Or do you prefer I chenge the prototype to:

> static int wm831x_buckv_set_voltage_sel(struct regulator_dev *rdev,
> unsigned vsel)

> Then the diff can be smaller.

Yes, this is the point. A huge proportion of the change is a cosmetic
change for this rename which makes it much harder to read and review.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]