Re: [PATCH RFT 3/4] regulator: wm831x-dcdc: Convert wm831x_buckv_ops to set_voltage_sel and map_voltage

Mark Brown
2012-06-13T10:03:45Z

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

On Tue, Jun 12, 2012 at 10:23:09AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

This patch is way more invasive than it needs to be (and therefore hard
to check) because

> - if (dcdc->dvs_gpio && dcdc->on_vsel == vsel)
> + if (dcdc->dvs_gpio && dcdc->on_vsel == selector)

you've replaced vsel with selector throughout the code.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]