public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Dave Young <dyoung@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Yinghai Lu <yinghai.lu@oracle.com>, Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] x86: revert "x86: Fix S4 regression"
Date: Tue, 12 Jun 2012 13:21:03 +0800	[thread overview]
Message-ID: <1339478463-31172-1-git-send-email-amwang@redhat.com> (raw)

From: Cong Wang <xiyou.wangcong@gmail.com>

This reverts the following commit:

	commit 8548c84da2f47e71bbbe300f55edb768492575f7
	Author: Takashi Iwai <tiwai@suse.de>
	Date:   Sun Oct 23 23:19:12 2011 +0200

	    x86: Fix S4 regression
	    
	    Commit 4b239f458 ("x86-64, mm: Put early page table high") causes a S4
	    regression since 2.6.39, namely the machine reboots occasionally at S4
	    resume.  It doesn't happen always, overall rate is about 1/20.  But,
	    like other bugs, once when this happens, it continues to happen.
	    
	    This patch fixes the problem by essentially reverting the memory
	    assignment in the older way.

According to the previous discussion:
http://marc.info/?l=linux-kernel&m=133161674120253&w=2
it seems that so far the best solution is just reverting it.

Takashi, could you help to test if the S4 regression is still
there after this patch?

Reported-by: CAI Qian <caiqian@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Yinghai Lu <yinghai.lu@oracle.com>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>

---
 arch/x86/mm/init.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index bc4e9d8..7ab7975 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -74,8 +74,9 @@ static void __init find_early_table_space(struct map_range *mr, unsigned long en
 #ifdef CONFIG_X86_32
 	/* for fixmap */
 	tables += roundup(__end_of_fixed_addresses * sizeof(pte_t), PAGE_SIZE);
-#endif
+
 	good_end = max_pfn_mapped << PAGE_SHIFT;
+#endif
 
 	base = memblock_find_in_range(start, good_end, tables, PAGE_SIZE);
 	if (!base)
-- 
1.7.7.6


             reply	other threads:[~2012-06-12  5:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12  5:21 Cong Wang [this message]
2012-06-15 11:11 ` [PATCH] x86: revert "x86: Fix S4 regression" Cong Wang
2012-06-15 12:15   ` Takashi Iwai
2012-06-15 19:09     ` Rafael J. Wysocki
2012-06-18  3:10     ` Cong Wang
2012-07-17  3:15 ` Takao Indoh
2012-07-23 10:00   ` Dave Young
2012-07-23 11:22     ` Takao Indoh
2012-07-23 12:51       ` Dave Young
2012-07-24 15:55       ` Cong Wang
2012-07-25  0:19         ` Takao Indoh
2012-08-06 20:42           ` Vivek Goyal
2012-08-06 21:55             ` Yinghai Lu
2012-08-11 17:57           ` Jerry Snitselaar
2012-08-11 18:26             ` Jerry Snitselaar
2012-08-11 18:34               ` H. Peter Anvin
2012-08-11 18:39                 ` H. Peter Anvin
2012-08-11 19:33                 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339478463-31172-1-git-send-email-amwang@redhat.com \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dyoung@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=tiwai@suse.de \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yinghai.lu@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox