From: Shuah Khan <shuahkhan@gmail.com>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: shuahkhan@gmail.com, Fabio Baltieri <fabio.baltieri@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] leds: use led_brightness_set in led_trigger_event
Date: Tue, 12 Jun 2012 11:15:08 -0600 [thread overview]
Message-ID: <1339521308.2628.13.camel@lorien2> (raw)
In-Reply-To: <CAK5ve-+D7vPO1U4gZDHRBmafJtF5T_EYBPCSAT2YOXjbc_u4zQ@mail.gmail.com>
>
> Thanks for catching this. It's a good idea we sort out those confusing name.
> Probably __led_set_bringness() is more conventional than _led_set_brightness().
>
> And might also need to revisit other function names.
>
> >> I can volunteer to make this change if we agree that this will be a good
> >> one to clear this naming confusion.
> >
>
> OK, good Shuah, please go ahead and submit patches and I will hold
> this patch for a while and wait for the final fixing.
>
Thanks. __led_set_brightness() sounds good. Will base patches off of
linux-leds devel unless that is not the right one.
-- Shuah
next prev parent reply other threads:[~2012-06-12 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 20:57 [PATCH] leds: use led_brightness_set in led_trigger_event Fabio Baltieri
2012-06-11 21:38 ` Shuah Khan
2012-06-12 7:16 ` Fabio Baltieri
2012-06-12 7:51 ` Bryan Wu
2012-06-12 17:15 ` Shuah Khan [this message]
2012-06-13 2:01 ` [PATCH] leds: Rename led_set_brightness() to __led_set_brightness() Shuah Khan
2012-06-13 4:25 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339521308.2628.13.camel@lorien2 \
--to=shuahkhan@gmail.com \
--cc=bryan.wu@canonical.com \
--cc=fabio.baltieri@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox