Re: [RFC 1/4] ARM: topology: Add arch_scale_freq_power function

Peter Zijlstra
2012-06-13T21:51:38Z

On Wed, 2012-06-13 at 20:27 +0100, Andy Whitcroft wrote:

> Actually if it was a new line, it would have been reported, at least in
> theory:
>
> # check for memory barriers without a comment.
> if ($line =~
> /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/)
> {
> if (!ctx_has_comment($first_line, $linenr)) {
> CHK("MEMORY_BARRIER",
> "memory barrier without comment\n" . $herecurr);
> }
> }

Oh sweet, we already have something for that.. But yeah I'd promote that
CHK to something stronger like Joe said. Maybe even error. Memory
barriers are magic, not adding proper comments should be a capital
offense.