scripts/get_maintainer.pl --help prints a warning

scripts/get_maintainer.pl --help prints a warning

[Paul Bolle]

0) "scripts/get_maintainer.pl --help" prints a warning (to stderr):
Use of uninitialized value $signature_pattern in concatenation (.) or
string at scripts/get_maintainer.pl line 723.

1) That must be caused by line 732:
        or use only ${signature_pattern} signers (default: $email_git_all_signature_types)

2) "git blame -L 732,+1 scripts/get_maintainer.pl" points to commit
683c6f8fcbcb6de8d07545ba70aff49e50d8bcf2 ("scripts/get_maintainer.pl:
improve --interactive UI"). And a quick look at that commit suggests it
introduced (most of) the current usage of $signature_pattern.

3) Would you have an idea how to silence that warning?


Paul Bolle

[PATCH] get_maintainer: Fix --help warning

[Joe Perches]

Using --help emits a concatenation error.
Fix it.

Reported-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Joe Perches <joe@perches.com>
---
 scripts/get_maintainer.pl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 0948c6b..8b673dd 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -83,6 +83,8 @@ push(@signature_tags, "Signed-off-by:");
 push(@signature_tags, "Reviewed-by:");
 push(@signature_tags, "Acked-by:");
 
+my $signature_pattern = "\(" . join("|", @signature_tags) . "\)";
+
 # rfc822 email address - preloaded methods go here.
 my $rfc822_lwsp = "(?:(?:\\r\\n)?[ \\t])";
 my $rfc822_char = '[\\000-\\377]';
@@ -473,7 +475,6 @@ my @subsystem = ();
 my @status = ();
 my %deduplicate_name_hash = ();
 my %deduplicate_address_hash = ();
-my $signature_pattern;
 
 my @maintainers = get_maintainers();
 

Re: [PATCH] get_maintainer: Fix --help warning

[Paul Bolle]

On Wed, 2012-06-13 at 11:41 -0700, Joe Perches wrote:
> Using --help emits a concatenation error.
> Fix it.
> 
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: Joe Perches <joe@perches.com>

Thanks. This made that warning go away.


Paul Bolle