Re: [PATCH 1/2] perf, x86: Add basic Ivy Bridge support v3

Andi Kleen
2012-06-14T13:41:45Z

> I really don't see the point of this patch,.. it is in fact using the
> SandyBridge events..

It needs a separate path for the PDIR change and for not doing the PEBS
workaround and for printing Ivy instead of Sandy. I had it originally merged in v1 with a
goto, but Ingo thought it was obfuscated, so it became a separate block.
If you disagree with Ingo please take it up with him.

> also you appear to have removed the backend stalls
> which per SDM (may 2012) table 19-2 would be the very same.

Stephane said that event doesn't exist anymore and I agree with him.
You cannot just base it on the SDM, it's SDM plus whatever is currently
known.

Besides they are misleading and wrong in any case.

-Andi
--
ak@linux.intel.com -- Speaking for myself only.