From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756404Ab2FNVT0 (ORCPT ); Thu, 14 Jun 2012 17:19:26 -0400 Received: from merlin.infradead.org ([205.233.59.134]:32977 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632Ab2FNVTZ convert rfc822-to-8bit (ORCPT ); Thu, 14 Jun 2012 17:19:25 -0400 Message-ID: <1339708758.2559.42.camel@twins> Subject: Re: [RFC][PATCH 4/4] sched/fair: Optimize cgroup pick_next_task_fair From: Peter Zijlstra To: mingo@kernel.org Cc: pjt@google.com, venki@google.com, efault@gmx.de, rostedt@goodmis.org, glommer@parallels.com, linux-kernel@vger.kernel.org Date: Thu, 14 Jun 2012 23:19:18 +0200 In-Reply-To: <20120614133212.810726968@chello.nl> References: <20120614132902.800827488@chello.nl> <20120614133212.810726968@chello.nl> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-06-14 at 15:29 +0200, Peter Zijlstra wrote: > Since commit 2f36825b1 ("sched: Next buddy hint on sleep and preempt > path") it is likely we pick a new task from the same cgroup, doing a put > and then set on all intermediate entities is a waste of time, so try to > avoid this. I just noticed put_prev_entity() also does the bandwidth enforcement stuff, I think I just broke that. Will have a peek at fixing that tomorrow or so.