[PATCH] extcon: max8997: Add missing kfree for info->edev in max8997_muic_remove()

[PATCH] extcon: max8997: Add missing kfree for info->edev in max8997_muic_remove()

[Axel Lin]

extcon_dev_unregister(info->edev) doest not free info->edev, we need to call
kfree(info->edev) here.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/extcon/extcon-max8997.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 5ecf176..a4ed30b 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -514,6 +514,7 @@ static int __devexit max8997_muic_remove(struct platform_device *pdev)
 
 	extcon_dev_unregister(info->edev);
 
+	kfree(info->edev);
 	kfree(info);
 
 	return 0;
-- 
1.7.9.5

Re: [PATCH] extcon: max8997: Add missing kfree for info->edev in max8997_muic_remove()

[함명주]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1838 bytes --]

> extcon_dev_unregister(info->edev) doest not free info->edev, we need to call
> kfree(info->edev) here.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

The patch is correct.

However, using devm_kzalloc at probe and removing kfree at remove appears to be much better.

Thank you.


Cheers!
MyungJoo.

> ---
>  drivers/extcon/extcon-max8997.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 5ecf176..a4ed30b 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -514,6 +514,7 @@ static int __devexit max8997_muic_remove(struct platform_device *pdev)
>  
>  	extcon_dev_unregister(info->edev);
>  
> +	kfree(info->edev);
>  	kfree(info);
>  
>  	return 0;
> -- 
> 1.7.9.5
> 
------
Sender : Axel Lin<axel.lin@gmail.com>
Date : 2012-06-16 22:25 (GMT+09:00)
Title : [PATCH] extcon: max8997: Add missing kfree for info->edev in max8997_muic_remove()

extcon_dev_unregister(info->edev) doest not free info->edev, we need to call
kfree(info->edev) here.

Signed-off-by: Axel Lin 
---
drivers/extcon/extcon-max8997.c |    1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 5ecf176..a4ed30b 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -514,6 +514,7 @@ static int __devexit max8997_muic_remove(struct platform_device *pdev)

extcon_dev_unregister(info->edev);

+ kfree(info->edev);
kfree(info);

return 0;
-- 
1.7.9.5






--
MyungJoo Ham (ÇÔ¸íÁÖ), PHD
System S/W Lab, S/W Platform Team, Software Center
Samsung Electronics
Cell: +82-10-6714-2858ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] extcon: max8997: Add missing kfree for info->edev in max8997_muic_remove()

[Axel Lin]

2012/6/18 함명주 <myungjoo.ham@samsung.com>:
>> extcon_dev_unregister(info->edev) doest not free info->edev, we need to call
>> kfree(info->edev) here.
>>
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> The patch is correct.
>
> However, using devm_kzalloc at probe and removing kfree at remove appears to be much better.
Yes, But I think Greg may prefer this one-linear for 3.5.
And another patch for the devm_kcalloc conversion for 3.6.

Regards,
Axel