From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762916AbXHPNWP (ORCPT ); Thu, 16 Aug 2007 09:22:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759546AbXHPNUF (ORCPT ); Thu, 16 Aug 2007 09:20:05 -0400 Received: from hellhawk.shadowen.org ([80.68.90.175]:1288 "EHLO hellhawk.shadowen.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762035AbXHPNUD (ORCPT ); Thu, 16 Aug 2007 09:20:03 -0400 From: Andy Whitcroft To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Andrew Morton , Andy Whitcroft , Andy Whitcroft , Samuel Ortiz , irda-users@lists.sourceforge.net Subject: [PATCH 5/6] irda_nl_get_mode: always results in failure References: InReply-To: Message-ID: <133bf74f7af4e972bbd7d32894d9d126@pinky> Date: Thu, 16 Aug 2007 14:19:06 +0100 X-SPF-Guess: neutral Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org It seems an extraneous trailing ';' has slipped in to the error handling for a name registration failure causing the error path to trigger unconditionally. Signed-off-by: Andy Whitcroft Cc: Samuel Ortiz Cc: irda-users@lists.sourceforge.net --- net/irda/irnetlink.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/irda/irnetlink.c b/net/irda/irnetlink.c index 694ea4d..1e429c9 100644 --- a/net/irda/irnetlink.c +++ b/net/irda/irnetlink.c @@ -106,7 +106,7 @@ static int irda_nl_get_mode(struct sk_buff *skb, struct genl_info *info) } if(nla_put_string(msg, IRDA_NL_ATTR_IFNAME, - dev->name)); + dev->name)) goto err_out; if(nla_put_u32(msg, IRDA_NL_ATTR_MODE, irlap->mode))