Re: [PATCH 5/5] thinkpad_acpi: Convert dbg_printk to tp_dbg and tp_vdbg

Joe Perches
2012-06-24T03:06:48Z

On Sat, 2012-06-23 at 21:40 -0300, Henrique de Moraes Holschuh wrote:
> On Sun, 17 Jun 2012, Joe Perches wrote:
> > Use a more current logging style.
> >
> > Add #define DEBUG and use pr_debug to enable dynamic debugging.
> > Coalesce formats and align arguments.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> Joe, are there any extra procedures required from the user to get the debug
> messages with this patch applied?

No.

The added #define DEBUG makes dynamic_debug emit those
messages automatically. Without the #define DEBUG, then
these tp_[v]dbg calls might not be compiled in at all.

These to_[v]dbg calls can be turned off via the normal
dyn_debug mechanisms.

see: Documentation/dynamic-debug-howto.txt

cheers, Joe