From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Mike Rapoport <mike@compulab.co.il>,
Danny Huang <dahuang@nvidia.com>, Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: regulator: tps6586x: What is the meaning of TPS6586X_SLEW_RATE_SET setting?
Date: Tue, 19 Jun 2012 19:15:22 +0800 [thread overview]
Message-ID: <1340104522.3964.1.camel@phoenix> (raw)
Hi Mike,
While looking at the datasheet (tps65860 and tps65862),
I don't understand why we have TPS6586X_SLEW_RATE_SET (0x08) in the code.
According to the datasheet, BIT3 of SM1SL/SM0SL is not used:
SM1SL [Addr 0x25]
SM0SL [Addr 0x28]
BIT[2:0] SM0/SM1 SUPPLY RAMP RATE
BIT[7:3] NOT USED
So why we need to check the "unused bit" in tps6586x_regulator_set_slew_rate()?
if (!(setting->slew_rate & TPS6586X_SLEW_RATE_SET))
return 0;
Regards,
Axel
next reply other threads:[~2012-06-19 11:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 11:15 Axel Lin [this message]
2012-06-20 8:04 ` regulator: tps6586x: What is the meaning of TPS6586X_SLEW_RATE_SET setting? Danny Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340104522.3964.1.camel@phoenix \
--to=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dahuang@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox