From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexandre Pereira da Silva <aletes.xgr@gmail.com>,
Florian Mickler <florian@mickler.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org
Subject: [PATCH] scripts/get_maintainer.pl: Test for non-standard signatures
Date: Wed, 20 Jun 2012 15:10:06 -0700 [thread overview]
Message-ID: <1340230206.29885.25.camel@joe2Laptop> (raw)
In-Reply-To: <20120620143959.394b9930.akpm@linux-foundation.org>
Warn on non-standard signature styles.
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 630319a..3e04f80 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1600,13 +1600,17 @@ sub process {
# Check signature styles
if (!$in_header_lines &&
- $line =~ /^(\s*)($signature_tags)(\s*)(.*)/) {
+ $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
my $space_before = $1;
my $sign_off = $2;
my $space_after = $3;
my $email = $4;
my $ucfirst_sign_off = ucfirst(lc($sign_off));
+ if ($sign_off !~ /$signature_tags/) {
+ WARN("BAD_SIGN_OFF",
+ "Non-standard signature: $sign_off\n" . $herecurr);
+ }
if (defined $space_before && $space_before ne "") {
WARN("BAD_SIGN_OFF",
"Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);
next prev parent reply other threads:[~2012-06-20 22:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 11:51 [PATCH] scripts/get_maintainer.pl: Add tested-by signature Alexandre Pereira da Silva
2012-06-20 16:25 ` Joe Perches
2012-06-20 21:39 ` Andrew Morton
2012-06-20 21:51 ` Jesper Juhl
2012-06-20 21:54 ` Joe Perches
2012-06-20 21:58 ` richard -rw- weinberger
2012-06-20 22:17 ` Joe Perches
2012-06-20 22:10 ` Joe Perches [this message]
2012-06-20 22:25 ` [PATCH] scripts/get_maintainer.pl: Test for non-standard signatures Joe Perches
[not found] ` <CAGxyxNCwESN4jsYYDRv6sFax4K4hBP5bOY12LEm_WsqKeGJHsA@mail.gmail.com>
2012-06-21 12:59 ` [PATCH] scripts/get_maintainer.pl: Add tested-by signature Alexandre Pereira da Silva
2012-06-21 16:36 ` Geert Uytterhoeven
2012-06-28 10:04 ` Peter Zijlstra
2012-06-28 18:09 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340230206.29885.25.camel@joe2Laptop \
--to=joe@perches.com \
--cc=Ian.Campbell@citrix.com \
--cc=akpm@linux-foundation.org \
--cc=aletes.xgr@gmail.com \
--cc=florian@mickler.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox