From: John Stultz <john.stultz@linaro.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: "Arve Hjønnevåg" <arve@android.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"John Stultz" <john.stultz@linaro.org>
Subject: [PATCH 14/15] ARM: etm: Add sysfs entry to disable branch_output flag
Date: Wed, 20 Jun 2012 18:47:46 -0400 [thread overview]
Message-ID: <1340232467-6023-15-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1340232467-6023-1-git-send-email-john.stultz@linaro.org>
From: Arve Hjønnevåg <arve@android.com>
Add sysfs entry to disable branch_output flag
CC: Russell King <linux@arm.linux.org.uk>
CC: Paul Gortmaker <paul.gortmaker@windriver.com>
CC: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Arve Hjønnevåg <arve@android.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
arch/arm/include/asm/hardware/coresight.h | 5 ++--
arch/arm/kernel/etm.c | 41 ++++++++++++++++++++++++++++-
2 files changed, 43 insertions(+), 3 deletions(-)
diff --git a/arch/arm/include/asm/hardware/coresight.h b/arch/arm/include/asm/hardware/coresight.h
index 47b7696..727ba0f 100644
--- a/arch/arm/include/asm/hardware/coresight.h
+++ b/arch/arm/include/asm/hardware/coresight.h
@@ -19,11 +19,13 @@
#define TRACER_CYCLE_ACC_BIT 2
#define TRACER_TRACE_DATA_BIT 3
#define TRACER_TIMESTAMP_BIT 4
+#define TRACER_BRANCHOUTPUT_BIT 5
#define TRACER_ACCESSED BIT(TRACER_ACCESSED_BIT)
#define TRACER_RUNNING BIT(TRACER_RUNNING_BIT)
#define TRACER_CYCLE_ACC BIT(TRACER_CYCLE_ACC_BIT)
#define TRACER_TRACE_DATA BIT(TRACER_TRACE_DATA_BIT)
#define TRACER_TIMESTAMP BIT(TRACER_TIMESTAMP_BIT)
+#define TRACER_BRANCHOUTPUT BIT(TRACER_BRANCHOUTPUT_BIT)
#define TRACER_TIMEOUT 10000
@@ -126,8 +128,7 @@
#define ETMR_VIEWDATACTRL3 0x3c
#define ETMVDC3_EXCLONLY BIT(16)
-#define ETMCTRL_OPTS (ETMCTRL_DO_CPRT | \
- ETMCTRL_BRANCH_OUTPUT)
+#define ETMCTRL_OPTS (ETMCTRL_DO_CPRT)
#define ETMR_ID 0x1e4
#define ETMIDR_VERSION(x) (((x) >> 4) & 0xff)
diff --git a/arch/arm/kernel/etm.c b/arch/arm/kernel/etm.c
index f00a3f39..8e84d5c 100644
--- a/arch/arm/kernel/etm.c
+++ b/arch/arm/kernel/etm.c
@@ -115,6 +115,9 @@ static int trace_start_etm(struct tracectx *t, int id)
if (t->flags & TRACER_CYCLE_ACC)
v |= ETMCTRL_CYCLEACCURATE;
+ if (t->flags & TRACER_BRANCHOUTPUT)
+ v |= ETMCTRL_BRANCH_OUTPUT;
+
if (t->flags & TRACER_TRACE_DATA)
v |= ETMCTRL_DATA_DO_ADDR;
@@ -683,6 +686,36 @@ static struct kobj_attribute trace_contextid_size_attr =
__ATTR(trace_contextid_size, 0644,
trace_contextid_size_show, trace_contextid_size_store);
+static ssize_t trace_branch_output_show(struct kobject *kobj,
+ struct kobj_attribute *attr,
+ char *buf)
+{
+ return sprintf(buf, "%d\n", !!(tracer.flags & TRACER_BRANCHOUTPUT));
+}
+
+static ssize_t trace_branch_output_store(struct kobject *kobj,
+ struct kobj_attribute *attr,
+ const char *buf, size_t n)
+{
+ unsigned int branch_output;
+
+ if (sscanf(buf, "%u", &branch_output) != 1)
+ return -EINVAL;
+
+ mutex_lock(&tracer.mutex);
+ if (branch_output)
+ tracer.flags |= TRACER_BRANCHOUTPUT;
+ else
+ tracer.flags &= ~TRACER_BRANCHOUTPUT;
+ mutex_unlock(&tracer.mutex);
+
+ return n;
+}
+
+static struct kobj_attribute trace_branch_output_attr =
+ __ATTR(trace_branch_output, 0644,
+ trace_branch_output_show, trace_branch_output_store);
+
static ssize_t trace_timestamp_show(struct kobject *kobj,
struct kobj_attribute *attr,
char *buf)
@@ -820,7 +853,7 @@ static int __devinit etm_probe(struct amba_device *dev, const struct amba_id *id
amba_set_drvdata(dev, t->etm_regs[t->etm_regs_count]);
- t->flags = TRACER_CYCLE_ACC | TRACER_TRACE_DATA;
+ t->flags = TRACER_CYCLE_ACC | TRACER_TRACE_DATA | TRACER_BRANCHOUTPUT;
t->etm_portsz = 1;
t->etm_contextid_size = 3;
@@ -861,6 +894,12 @@ static int __devinit etm_probe(struct amba_device *dev, const struct amba_id *id
dev_dbg(&dev->dev,
"Failed to create trace_contextid_size in sysfs\n");
+ ret = sysfs_create_file(&dev->dev.kobj,
+ &trace_branch_output_attr.attr);
+ if (ret)
+ dev_dbg(&dev->dev,
+ "Failed to create trace_branch_output in sysfs\n");
+
if (etmccer & ETMCCER_TIMESTAMPING_IMPLEMENTED) {
ret = sysfs_create_file(&dev->dev.kobj,
&trace_timestamp_attr.attr);
--
1.7.9.5
next prev parent reply other threads:[~2012-06-20 22:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 22:47 [PATCH 00/15] Android ETM driver changes John Stultz
2012-06-20 22:47 ` [PATCH 01/15] ARM: etm: Don't require clock control John Stultz
2012-06-28 15:47 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 02/15] ARM: etm: Don't limit tracing to only non-secure code John Stultz
2012-06-28 15:49 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 03/15] ARM: etm: Don't try to clear the buffer full status after reading the buffer John Stultz
2012-06-20 22:47 ` [PATCH 04/15] ARM: etm: Allow range selection John Stultz
2012-06-28 15:54 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 05/15] ARM: etm: Configure data tracing John Stultz
2012-06-28 15:55 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 06/15] ARM: etm: Add some missing locks and error checks John Stultz
2012-06-28 15:56 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 07/15] ARM: etm: Return the entire trace buffer if it is empty after reset John Stultz
2012-06-28 15:57 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 08/15] ARM: etm: Support multiple ETMs/PTMs John Stultz
2012-06-28 16:00 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 09/15] ARM: etm: Power down etm(s) when tracing is not enabled John Stultz
2012-06-28 16:01 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 10/15] ARM: etm: Wait for etm/ptm(s) to stop before requesting PowerDown John Stultz
2012-06-28 16:02 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 11/15] ARM: etm: Check arch version and disable data tracing for ptm John Stultz
2012-06-28 16:07 ` Linus Walleij
2012-06-28 21:31 ` Arve Hjønnevåg
2012-06-30 19:34 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 12/15] ARM: etm: Add sysfs entry to enable timestamps if supported John Stultz
2012-06-28 16:08 ` Linus Walleij
2012-06-20 22:47 ` [PATCH 13/15] ARM: etm: Add sysfs entry to set context-id-size John Stultz
2012-06-28 16:10 ` Linus Walleij
2012-06-20 22:47 ` John Stultz [this message]
2012-06-28 16:10 ` [PATCH 14/15] ARM: etm: Add sysfs entry to disable branch_output flag Linus Walleij
2012-06-20 22:47 ` [PATCH 15/15] ARM: etm: Add sysfs entry to enable return stack if supported John Stultz
2012-06-28 16:11 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340232467-6023-15-git-send-email-john.stultz@linaro.org \
--to=john.stultz@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=arve@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox