Re: [PATCH 11/15] ARM: etm: Check arch version and disable data tracing for ptm

Linus Walleij
2012-06-30T19:34:19Z

On Thu, Jun 28, 2012 at 11:31 PM, Arve Hjønnevåg <arve@android.com> wrote:
> On Thu, Jun 28, 2012 at 9:07 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Thu, Jun 21, 2012 at 12:47 AM, John Stultz <john.stultz@linaro.org> wrote:
>>
>>> +#define ETMR_ID 0x1e4
>>> +#define ETMIDR_VERSION(x) (((x) >> 4) & 0xff)

Damned I was reading 0x0fe4 ...

> Those values do not come from the same register. The revision is
> duplicated there, but I did not find the major and minor etm version
> which is what I'm looking at.

OK sorry for getting this backwards.

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij