From: Daniel Lawrence <daniel@danielscottlawrence.com>
To: abbotti@mev.co.uk, fmhess@users.sourceforge.net,
gregkh@linuxfoundation.org, hsweeten@visionengravers.com
Cc: daniel@danielscottlawrence.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] Staging: comedi: fixed printk coding style issue in acl7225b.c
Date: Sat, 23 Jun 2012 12:51:43 +1000 [thread overview]
Message-ID: <1340419903-21928-1-git-send-email-daniel@danielscottlawrence.com> (raw)
This is a patch to the acl7225.b file that fixes up 2 printk warnings
found by the checkpatch.pl tool.
As this is a comedi driver the printk's have been changed to the
dev_printk style.
Signed-off-by: Daniel Lawrence <daniel@danielscottlawrence.com>
---
drivers/staging/comedi/drivers/acl7225b.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
index 4e4fc41..ca74519 100644
--- a/drivers/staging/comedi/drivers/acl7225b.c
+++ b/drivers/staging/comedi/drivers/acl7225b.c
@@ -72,11 +72,11 @@ static int acl7225b_attach(struct comedi_device *dev,
iobase = it->options[0];
iorange = this_board->io_range;
- printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
+ dev_info(dev->class_dev, "acl7225b: board=%s 0x%04x\n",
this_board->name, iobase);
if (!request_region(iobase, iorange, "acl7225b")) {
- printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n",
- dev->minor);
+ dev_err(dev->class_dev,
+ "request_region failed - I/O port conflict\n");
return -EIO;
}
dev->board_name = this_board->name;
--
1.7.9.5
next reply other threads:[~2012-06-23 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 2:51 Daniel Lawrence [this message]
2012-06-23 3:48 ` [PATCH] Staging: comedi: fixed printk coding style issue in acl7225b.c Greg KH
2012-06-23 3:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340419903-21928-1-git-send-email-daniel@danielscottlawrence.com \
--to=daniel@danielscottlawrence.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox