Re: [PATCH] grvga: Fix error handling issues

Dan Carpenter
2012-06-23T22:33:38Z

On Fri, Jun 22, 2012 at 06:11:19PM +0200, Emil Goode wrote:
> This patch fixes two problems with the error handling in the
> grvga_probe function.
>
> - If the call to grvga_parse_custom on line 370 fails we use
> the wrong label so that release_mem_region will be called
> without a call to request_mem_region being made.
>
> - If the call to ioremap on line 436 fails we should not try
> to call iounmap. I added an if statement to check whether or
> not a call to iounmap should be made.
>

Doesn't iounmap() have a check for NULL? On x86 it does.

if ((void __force *)addr <= high_memory)
return;

regards,
dan carpenter