From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, swetland@google.com,
Sherwin Soltani <sherwin@wybc.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: android: fix binder.c printk macros
Date: Mon, 25 Jun 2012 10:30:08 -0700 [thread overview]
Message-ID: <1340645408.3359.4.camel@joe2Laptop> (raw)
In-Reply-To: <20120625172423.GA1935@kroah.com>
On Mon, 2012-06-25 at 10:24 -0700, Greg KH wrote:
> On Mon, Jun 25, 2012 at 10:20:00AM -0700, Joe Perches wrote:
> > Your patch-bot needs work.
> >
> > Converting printks to pr_<level> is trivial
> > and should be done all at once, not piecemeal.
>
> I'm not disagreeing with that, unfortunately this patch also did more
> than just pr_<level> conversions, which is why my patch-bot kicked in.
>
> So your patch-bot complaint generator needs work :)
Or not. I think wholesale whitespace changes are just
fine too.
git diff -w can ignore all those things pretty easily.
Using a bot is certainly sensible and sanity-preserving.
I think it just needs a little tweaking.
cheers, Joe
next prev parent reply other threads:[~2012-06-25 17:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 6:09 [PATCH] drivers: staging: android: fix binder.c printk macros Sherwin Soltani
2012-06-25 17:17 ` Greg KH
2012-06-25 17:20 ` Joe Perches
2012-06-25 17:24 ` Greg KH
2012-06-25 17:30 ` Joe Perches [this message]
2012-06-25 17:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340645408.3359.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sherwin@wybc.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox