From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Cong Wang <amwang@redhat.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
dhowells <dhowells@redhat.com>
Subject: Re: [PATCH 00/12] kmap_atomic cleanup for 3.6
Date: Mon, 25 Jun 2012 19:35:35 +0200 [thread overview]
Message-ID: <1340645735.18025.88.camel@twins> (raw)
In-Reply-To: <201206251518.08791.arnd@arndb.de>
On Mon, 2012-06-25 at 15:18 +0000, Arnd Bergmann wrote:
> > Different arch has different values for KM_TYPE_NR, I am not sure if
> > unifying them to a fixed value could fit all?
No you can't. Some arch's have arch specific KM_TYPE thingies, like FRV.
> > For safety, I kept their original values.
>
> My fear is that it will make it harder to clean that code up for
> real, when there is no longer an indication about where the number
> comes from.
Agreed, I'd much prefer it if we'd come up with a sane way to compute
the max value before doing away with these enums.
Sadly I haven't been able to come up with a sane way short of whole
program analysis.
next prev parent reply other threads:[~2012-06-25 17:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-23 10:04 [PATCH 00/12] kmap_atomic cleanup for 3.6 Cong Wang
2012-06-23 10:04 ` [PATCH 01/12] jbd2: remove the second argument of kmap_atomic Cong Wang
2012-06-23 10:04 ` [PATCH 02/12] arm: remove km_type definitions Cong Wang
2012-06-23 10:04 ` [PATCH 03/12] powerpc: " Cong Wang
2012-06-23 10:04 ` [PATCH 04/12] frv: " Cong Wang
2012-06-26 20:25 ` Geert Uytterhoeven
2012-06-27 3:24 ` Cong Wang
2012-06-27 7:32 ` Geert Uytterhoeven
2012-06-23 10:04 ` [PATCH 05/12] avr32: " Cong Wang
2012-06-26 7:28 ` Hans-Christian Egtvedt
2012-06-23 10:04 ` [PATCH 06/12] asm-generic: " Cong Wang
2012-06-23 10:04 ` [PATCH 07/12] um: " Cong Wang
2012-06-23 10:04 ` [PATCH 08/12] tile: " Cong Wang
2012-06-26 17:48 ` Chris Metcalf
2012-06-23 10:04 ` [PATCH 09/12] highmem: remove the deprecated form of kmap_atomic Cong Wang
2012-06-23 10:04 ` [PATCH 10/12] feature-removal-schedule.txt: remove kmap_atomic(page, km_type) Cong Wang
2012-06-23 10:04 ` [PATCH 11/12] vmalloc: remove KM_USER0 from comments Cong Wang
2012-06-23 10:04 ` [PATCH 12/12] pipe: " Cong Wang
2012-06-23 21:11 ` [PATCH 00/12] kmap_atomic cleanup for 3.6 Arnd Bergmann
2012-06-25 4:26 ` Cong Wang
2012-06-25 15:18 ` Arnd Bergmann
2012-06-25 17:35 ` Peter Zijlstra [this message]
2012-06-25 20:43 ` Arnd Bergmann
2012-06-26 8:17 ` Peter Zijlstra
2012-06-26 11:49 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340645735.18025.88.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox