From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Lange <thomas@corelatus.se>
Cc: mingo@redhat.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [BUG] sched: clock wrap bug in 2.6.35-stable kills scheduling
Date: Mon, 25 Jun 2012 21:33:27 +0200 [thread overview]
Message-ID: <1340652807.21991.19.camel@twins> (raw)
In-Reply-To: <4FE8B2D1.3070600@corelatus.se>
On Mon, 2012-06-25 at 20:49 +0200, Thomas Lange wrote:
> Commit fe44d62 removed the if-clause that caused the problem. Most likely, this
> solved the problem.
Ah, probably. IIRC we also fixed the short wrap of those arm clocks
since.
> > If anything, I think something like the below ought to cure things.
>
> I agree. Either we make sure that sched_clock() never wraps or if it wraps,
> that it wraps shortly after boot to catch problems early.
Right, sched_clock() should only ever wrap on the full u64.
prev parent reply other threads:[~2012-06-25 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 17:32 [BUG] sched: clock wrap bug in 2.6.35-stable kills scheduling Thomas Lange
2012-06-24 17:52 ` Greg KH
2012-06-25 9:45 ` Peter Zijlstra
2012-06-25 10:38 ` Peter Zijlstra
2012-06-25 18:49 ` Thomas Lange
2012-06-25 19:33 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340652807.21991.19.camel@twins \
--to=peterz@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=thomas@corelatus.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox