public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Chiwoong Byun <woong.byun@samsung.com>,
	Jonghwa Lee <jonghwa3.lee@samsung.com>,
	Myungjoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Yadwinder Singh Brar <yadi.brar@samsung.com>,
	SamuelOrtiz <sameo@linux.intel.com>
Subject: [PATCH] mfd: MFD_MAX77686 needs to select REGMAP_I2C and IRQ_DOMAIN
Date: Tue, 26 Jun 2012 09:26:48 +0800	[thread overview]
Message-ID: <1340674008.2942.1.camel@phoenix> (raw)

Select REGMAP_I2C to fix below build errors:

  CC      drivers/mfd/max77686.o
drivers/mfd/max77686.c:43:15: error: variable 'max77686_regmap_config' has initializer but incomplete type
drivers/mfd/max77686.c:44:2: error: unknown field 'reg_bits' specified in initializer
drivers/mfd/max77686.c:44:2: warning: excess elements in struct initializer [enabled by default]
drivers/mfd/max77686.c:44:2: warning: (near initialization for 'max77686_regmap_config') [enabled by default]
drivers/mfd/max77686.c:45:2: error: unknown field 'val_bits' specified in initializer
drivers/mfd/max77686.c:45:2: warning: excess elements in struct initializer [enabled by default]
drivers/mfd/max77686.c:45:2: warning: (near initialization for 'max77686_regmap_config') [enabled by default]
drivers/mfd/max77686.c: In function 'max77686_i2c_probe':
drivers/mfd/max77686.c:60:2: error: implicit declaration of function 'regmap_init_i2c' [-Werror=implicit-function-declaration]
drivers/mfd/max77686.c:60:19: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mfd/max77686.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2

Select IRQ_DOMAIN to fix below build errors:

  CC      drivers/mfd/max77686-irq.o
drivers/mfd/max77686-irq.c: In function 'max77686_irq_thread':
drivers/mfd/max77686-irq.c:213:4: error: implicit declaration of function 'irq_find_mapping' [-Werror=implicit-function-declaration]
drivers/mfd/max77686-irq.c: In function 'max77686_irq_init':
drivers/mfd/max77686-irq.c:282:2: error: implicit declaration of function 'irq_domain_add_linear' [-Werror=implicit-function-declaration]
drivers/mfd/max77686-irq.c:282:9: warning: assignment makes pointer from integer without a cast [enabled by default]
cc1: some warnings being treated as errors
make[2]: *** [drivers/mfd/max77686-irq.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/mfd/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 3b59661..a7d0c85 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -426,6 +426,8 @@ config MFD_MAX77686
 	bool "Maxim Semiconductor MAX77686 PMIC Support"
 	depends on I2C=y && GENERIC_HARDIRQS
 	select MFD_CORE
+	select REGMAP_I2C
+	select IRQ_DOMAIN
 	help
 	  Say yes here to support for Maxim Semiconductor MAX77686.
 	  This is a Power Management IC with RTC on chip.
-- 
1.7.9.5




             reply	other threads:[~2012-06-26  1:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26  1:26 Axel Lin [this message]
2012-06-26  8:53 ` [PATCH] mfd: MFD_MAX77686 needs to select REGMAP_I2C and IRQ_DOMAIN Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340674008.2942.1.camel@phoenix \
    --to=axel.lin@gmail.com \
    --cc=jonghwa3.lee@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=sameo@linux.intel.com \
    --cc=woong.byun@samsung.com \
    --cc=yadi.brar@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox