From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755628Ab2F0JRH (ORCPT ); Wed, 27 Jun 2012 05:17:07 -0400 Received: from merlin.infradead.org ([205.233.59.134]:43923 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201Ab2F0JRF convert rfc822-to-8bit (ORCPT ); Wed, 27 Jun 2012 05:17:05 -0400 Message-ID: <1340788213.10063.0.camel@twins> Subject: Re: [PATCH V5 0/13] perf: Intel uncore pmu counting support From: Peter Zijlstra To: Stephane Eranian Cc: "Yan, Zheng" , mingo@elte.hu, jolsa@redhat.com, andi@firstfloor.org, linux-kernel@vger.kernel.org Date: Wed, 27 Jun 2012 11:10:13 +0200 In-Reply-To: References: <1339479468-3815-1-git-send-email-zheng.z.yan@intel.com> <4FD7EFCB.6060005@intel.com> <1339578142.31548.128.camel@twins> <4FD949FF.7060207@intel.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-06-27 at 03:05 +0200, Stephane Eranian wrote: > If you compile the uncore support in 32-bit mode, you will > get a warning on the hrtimer_start_range_ns() functions > because the interval is passed as ktime_t whereas the > function expects unsigned long. With 64-bit, no problem > ktime_t is a union with s64. But in 32-bit mode, there is > a possible truncation of the delta. This needs to be > fixed. Right, Andrew has a patch for that, I guess I'd better make sure it appears in tip as well.