From: Steven Rostedt <rostedt@goodmis.org>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: big allocation failure during tracing init.
Date: Wed, 27 Jun 2012 22:58:26 -0400 [thread overview]
Message-ID: <1340852306.16702.74.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20120628022218.GA30698@redhat.com>
On Wed, 2012-06-27 at 22:22 -0400, Dave Jones wrote:
> On Wed, Jun 27, 2012 at 08:52:43PM -0400, Steven Rostedt wrote:
> > On Fri, 2012-06-22 at 15:36 -0400, Dave Jones wrote:
> >
> > > I guess the problem is on kernels built with CONFIG_MAXCPUS, struct trace_iterator
> > > can be pretty large due to this embedded in it..
> > >
> > > struct ring_buffer_iter *buffer_iter[NR_CPUS];
> > >
> > > Any thoughts on how to change that to a smaller dynamic data structure,
> > > without adding too much overhead to tracing ? (I'm assuming a linked-list walk
> > > for eg would be excessive?)
> > >
> >
> > Does this patch fix it for you?
>
> I'm not sure what I did to trigger the allocation failure last time,
> but I'll run with this for a while, and see if anything falls out.
You probably need to do some tracing to trigger it. As it requires
opening of the trace files.
-- Steve
prev parent reply other threads:[~2012-06-28 2:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 19:36 big allocation failure during tracing init Dave Jones
2012-06-28 0:52 ` Steven Rostedt
2012-06-28 2:22 ` Dave Jones
2012-06-28 2:58 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340852306.16702.74.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).