From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754527Ab2F1Nv0 (ORCPT ); Thu, 28 Jun 2012 09:51:26 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:40810 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813Ab2F1NvZ (ORCPT ); Thu, 28 Jun 2012 09:51:25 -0400 Message-ID: <1340891471.4994.10.camel@localhost> Subject: Re: [PATCH] apple-gmux: Correctly depend on apple_bl for building From: Arun Raghavan To: Seth Forshee Cc: Matthew Garrett , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 28 Jun 2012 19:21:11 +0530 In-Reply-To: <20120628134806.GB15308@thinkpad-t410> References: <1340879796-30262-1-git-send-email-arun.raghavan@collabora.co.uk> <20120628132058.GA15308@thinkpad-t410> <1340889815.4994.4.camel@localhost> <20120628134806.GB15308@thinkpad-t410> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-06-28 at 08:48 -0500, Seth Forshee wrote: > On Thu, Jun 28, 2012 at 06:53:35PM +0530, Arun Raghavan wrote: > > On Thu, 2012-06-28 at 08:20 -0500, Seth Forshee wrote: > > > On Thu, Jun 28, 2012 at 04:06:36PM +0530, Arun Raghavan wrote: > > > > apple_bl_register/unregister() are unconditionally used now, so we need > > > > to make sure that apple_bl is selected appropriately (built-in/module) > > > > if apple-gmux is being built. > > > > > > apple_bl.h provides stubs for these functions when apple_bl is not > > > built, so this shouldn't be necessary. Are you encoutering a situation > > > that causes build problems? > > > > Yes, I am. With CONFIG_BACKLIGHT_APPLE=m and CONFIG_APPLE_GMUX=y, I see > > the following error: > > > > LD init/built-in.o > > drivers/built-in.o: In function `gmux_probe': > > apple-gmux.c:(.devinit.text+0xa769): undefined reference to `apple_bl_unregister' > > drivers/built-in.o: In function `gmux_remove': > > apple-gmux.c:(.devexit.text+0x46d): undefined reference to `apple_bl_register' > > Yuck. In that case I don't think your patch probably goes far enough to > fix your situation. > > As far as I know select isn't recursive, i.e. it won't select the > dependencies of the thing you select. I missed the stubs, so the patch should probably just be adding this line: depends on APPLE_BACKLIGHT = n || APPLE_BACKLIGHT but that conflicts with the 'select BACKLIGHT_CLASS_DEVICE' (a recursive dependency is detected). -- Arun