From: joeyli <jlee@suse.com>
To: seth.forshee@canonical.com
Cc: Richard Purdie <rpurdie@rpsys.net>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Corentin Chary <corentin.chary@gmail.com>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH] backlight: add support for disabling backlights via sysfs
Date: Fri, 29 Jun 2012 10:43:59 +0800 [thread overview]
Message-ID: <1340937839.6196.212.camel@linux-s257.site> (raw)
In-Reply-To: <20120628211936.GA14286@srcf.ucam.org>
於 四,2012-06-28 於 22:19 +0100,Matthew Garrett 提到:
> On Thu, Jun 28, 2012 at 04:16:00PM -0500, Seth Forshee wrote:
>
> > What I still don't understand is your reason for preferring
> > driver-specific interfaces for disabling backlights to a single generic
> > interface. Are you afraid that allowing it to be done from userspace
> > will make it too easy, and as a result quirks will be applied without
> > attempting to fix the problem (i.e. the quriking should go through a
> > kernel dev to ensure someone tries to fix the problem is made before
> > applying a quirk)?
>
> Yup, that. We'll just end up with three billion forum posts telling
> people to add a line to a text file and nobody will ever fix the real
> problem.
>
Yes, we can not just hide this issue. It's entirely a manufacturers'
problem.
More and more machines have broken _BCM is because ODM didn't really
follow WDDM spec to maintain standard acpi interface for compatibility,
e.g. XP or Linux that don't support WDDM:
http://msdn.microsoft.com/en-us/windows/hardware/gg487382.aspx
In WDDM architecture, in spec p.5, there have a "Monitor" driver to
check the WDDM driver support brightness DDI, if not, then it will use
standard acpi method to control brightness.
Unfortunately, no OEM preload Windows XP, now. So, more and more ODM
didn't test _BCM, actaully, they never test it, ODM QA just test the
brightness control UI available on newest Windows version (Windows 7).
We cann't just follow windows approach because it causes standard acpi
method neglected. If we also do that, then _BCM function will have no
chance to fix by any manufacturers because it's really nobody care.
Currently, on Linux we default use _BCM to control brightness, video
driver is a fallback. And we enable this fallback in platform driver.
It can keep still have people pay attention on standard acpi methods.
Thanks a lot!
Joey Lee
next prev parent reply other threads:[~2012-06-29 2:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 19:07 [PATCH] backlight: add support for disabling backlights via sysfs Seth Forshee
2012-06-28 19:10 ` Matthew Garrett
2012-06-28 19:30 ` Seth Forshee
2012-06-28 19:36 ` Matthew Garrett
2012-06-28 21:16 ` Seth Forshee
2012-06-28 21:19 ` Matthew Garrett
2012-06-29 2:43 ` joeyli [this message]
2012-06-29 2:57 ` Matthew Garrett
2012-06-29 7:18 ` joeyli
2012-06-29 12:24 ` Corentin Chary
2012-06-29 14:11 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340937839.6196.212.camel@linux-s257.site \
--to=jlee@suse.com \
--cc=corentin.chary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox