From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Oleg Nesterov <oleg@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
". James Morris" <jmorris@namei.org>,
linux-security-module@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 0/4] Was: deferring __fput()
Date: Fri, 29 Jun 2012 01:30:38 -0400 [thread overview]
Message-ID: <1340947838.2293.2.camel@falcor> (raw)
In-Reply-To: <20120628043836.GW14083@ZenIV.linux.org.uk>
On Thu, 2012-06-28 at 05:38 +0100, Al Viro wrote:
> On Wed, Jun 27, 2012 at 08:37:21PM +0200, Oleg Nesterov wrote:
> > On 06/25, Oleg Nesterov wrote:
> > >
> > > And if it always takes ->pi_lock we do not need the new PF_ or something
> > > else, exit_task_work() can set task->task_works = NO_MORE under ->pi_lock
> > > (task_work_run() can check PF_EXITING), and task_work_add() ensures that
> > > task_works != NO_MORE.
> > >
> > > What do you think?
> >
> > It is not clear to me if you agree or not. So I am simply sending the
> > patches I have.
> >
> > Feel free to ignore or re-do.
> >
> > Seriously, why should we add 2 pointers into task_struct? Sure, this
> > is minor, but still... But perhaps task_work.c should not play tricks
> > with the circular list, task_work_run() can reverse the list as you
> > initially suggested.
> >
> > Also, I am not sure about "define rcu_head callback_head", this series
> > doesn't do this. But again, up to you.
>
> Umm... FWIW, my variant circa yesterday is in vfs.git#untested; it seems to survive
> on uml/amd64 at least. I'll look through your patches and see what can be nicked.
> The list removal logics in mine looks really ugly ;-/
Still failing to boot. Fails to boot starting with commit "b24dfa6
switch fput to task_work_add".
Mimi
next prev parent reply other threads:[~2012-06-29 5:31 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-22 12:44 deferring __fput() Mimi Zohar
2012-06-23 9:20 ` Al Viro
2012-06-23 19:45 ` Al Viro
2012-06-23 20:38 ` Oleg Nesterov
2012-06-23 21:01 ` Al Viro
2012-06-23 21:11 ` Al Viro
2012-06-24 4:16 ` Al Viro
2012-06-24 10:09 ` Al Viro
2012-06-24 16:54 ` Oleg Nesterov
2012-06-24 15:33 ` Oleg Nesterov
2012-06-25 6:03 ` Al Viro
2012-06-25 15:18 ` Oleg Nesterov
2012-06-27 18:37 ` [PATCH 0/4] Was: " Oleg Nesterov
2012-06-27 18:37 ` [PATCH 1/4] task_work: use the single-linked list to shrink sizeof(task_work) Oleg Nesterov
2012-06-27 18:37 ` [PATCH 2/4] task_work: don't rely on PF_EXITING Oleg Nesterov
2012-06-27 18:38 ` [PATCH 3/4] task_work: deal with task_work callbacks adding more work Oleg Nesterov
2012-06-27 18:38 ` [PATCH 4/4] task_work: kill task_work->data Oleg Nesterov
2012-06-27 19:05 ` Oleg Nesterov
2012-06-28 4:38 ` [PATCH 0/4] Was: deferring __fput() Al Viro
2012-06-28 16:22 ` Oleg Nesterov
2012-06-28 16:45 ` Oleg Nesterov
2012-06-30 6:24 ` Al Viro
2012-06-30 17:41 ` Oleg Nesterov
2012-06-29 5:30 ` Mimi Zohar [this message]
2012-06-29 8:33 ` Al Viro
2012-06-29 13:02 ` Mimi Zohar
2012-06-29 17:41 ` Al Viro
2012-06-29 21:38 ` Mimi Zohar
2012-06-29 23:56 ` Mimi Zohar
2012-06-30 5:02 ` Al Viro
2012-07-01 19:50 ` Mimi Zohar
2012-07-01 20:57 ` Al Viro
2012-07-02 1:46 ` Mimi Zohar
2012-07-02 3:43 ` Al Viro
2012-07-02 5:11 ` Al Viro
2012-07-02 11:49 ` Mimi Zohar
2012-07-02 12:02 ` Al Viro
2012-07-02 13:01 ` Mimi Zohar
2012-07-02 13:33 ` Al Viro
2012-07-02 14:50 ` Mimi Zohar
2012-08-21 13:05 ` [PATCH] task_work: add a scheduling point in task_work_run() Eric Dumazet
2012-08-21 20:37 ` Mimi Zohar
2012-08-21 21:32 ` Eric Dumazet
2012-08-22 3:13 ` Mimi Zohar
2012-08-22 5:27 ` Michael Wang
2012-08-22 5:38 ` Al Viro
2012-06-23 20:57 ` deferring __fput() Al Viro
2012-06-23 21:33 ` Al Viro
2012-06-24 15:20 ` Oleg Nesterov
2012-06-24 18:11 ` Oleg Nesterov
2012-06-25 12:03 ` Peter Zijlstra
2012-06-25 12:14 ` Al Viro
2012-06-25 13:19 ` Peter Zijlstra
2012-06-25 13:53 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340947838.2293.2.camel@falcor \
--to=zohar@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).