From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752068AbbJLPPo (ORCPT ); Mon, 12 Oct 2015 11:15:44 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:64855 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbbJLPPm (ORCPT ); Mon, 12 Oct 2015 11:15:42 -0400 From: Arnd Bergmann To: John Garry Cc: James.Bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxarm@huawei.com, zhangfei.gao@linaro.org, linux-scsi@vger.kernel.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, hare@suse.de Subject: Re: [PATCH 05/25] scsi: hisi_sas: allocate memories and create pools Date: Mon, 12 Oct 2015 17:15:28 +0200 Message-ID: <13409618.ra2GB8eyNb@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1444663237-238302-6-git-send-email-john.garry@huawei.com> References: <1444663237-238302-1-git-send-email-john.garry@huawei.com> <1444663237-238302-6-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:jAE5heJyk8Y+ykGeEvfaU1oHCD9ofi5pZECfQ57YLLeMB8U2qAk v+uWGHPZ0cXDRZquGHvE5PbO2fKKmA9k2cSYbaUJMppsEIM0tf94Mre+6qZStt/aMBlblSi RNBs2F7WoC9TAYi+mq84HWpXauZ4RZ/1wS3Qe2Zrxw49mOu0Fv5yrs4UMybw+phy+RhgE8I UNVFzXq0uOw3FYHmR/Yow== X-UI-Out-Filterresults: notjunk:1;V01:K0:hW2SxRWu1IE=:ptKO3sGZdGqRIR70os/2kG yr9TsuUI6HaKJ8+/1plEZjAnCLnIUxjhNY/8j4VAsJBODepdxlStJyT17SpfKAah/TCP/h+PO C3/ZUniXViRe+pI6+kgulyFEGTzMEVUNMQeEWI8yiaoAqQAHDZjAeDZybQShoNzoD1JhYGtFU +36PMdFNbIiAW10JLmP3OIVQyvfJtT65x6nABf2jMe4aMiOYi3UjuuOtuCpcDVIF1X0WgEUMH cXTBlIZoxMqesjmH2GLkRDJsidkOrMI9b8t0h0bohlfb99I2oxekJy8A+GrEU27hJIzipndch 1q2osej3+XseiQmzOrwhqNnLOSBlS/i1Efpbj/yjQ9m0Bt9TCrOgQojGRJJVGgUzzLbP0KkxO HiWbx3QHngypaCa8dN7qc77c7aehAlthIg7Sh+mfUHq5jx+5vynkUV8zMZVvRt8oOGdUULrdw 7Hjv/Q1ATrVKJCvi5yLkya8ebvGEIAYsz6wj7AShcpszA9U67KabHxkMGTHwwJJEuRIC0Kcc6 uCAKTAeULeCBLG9eZQKAxN1eDdRHJMsYOjfV2QSwH3sdTZGGVxK48JcMVn70o5+wCjbOVJSDn T0Sm/mBLtMEdYVL3u4kzJLvVBxgk0LDN3ivj0ZQtR++L2CFiVNY5hLIbfp7qzOfh2iTwESGjN QigWtj4wildpqDLpJcZi0CMi3toVIOrlIJX7LIP5SCa9Vv68JCIABUGOmLCCnmzMUiAYSXDoZ WOowIwtvn8wyar0B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 12 October 2015 23:20:17 John Garry wrote: > + interrupt_count = of_property_count_u32_elems(np, "interrupts"); > + if (interrupt_count < 0) > + goto err_out; > + > + if (of_property_read_u32(np, "#interrupt-cells", &interrupt_cells)) > + goto err_out; > + > + hisi_hba->int_names = devm_kcalloc(&pdev->dev, > + interrupt_count / interrupt_cells, > + HISI_SAS_NAME_LEN, > + GFP_KERNEL); > This computation looks wrong: the "interrupts" property refers to interrupts that are referenced by this node and provided by an interrupt-controller, while the "#interrupt-cells" property refers to interrupts provided by this node. They don't need to have any relation. Arnd