From: Pablo Vazquez Rodriguez <peibolvigo@gmail.com>
To: greg@kroah.com
Cc: swetland@google.com, john.stultz@linaro.org, arve@android.com,
ccross@android.com, bringert@android.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Pablo Vazquez Rodriguez <peibolvigo@gmail.com>
Subject: [PATCH] Staging: android: fix pr_info and pr_err coding style issues in ashmem.c
Date: Fri, 29 Jun 2012 18:27:12 +0200 [thread overview]
Message-ID: <1340987232-25169-1-git-send-email-peibolvigo@gmail.com> (raw)
In-Reply-To: <y>
This is a patch to the ashmem.c file that fixes up several pr_info and pr_err warnings found by the checkpath.pl tool
Signed-off-by: Pablo Vazquez Rodriguez <peibolvigo@gmail.com>
---
drivers/staging/android/ashmem.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index e84dbec..01e61c9 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -707,7 +707,7 @@ static int __init ashmem_init(void)
sizeof(struct ashmem_area),
0, 0, NULL);
if (unlikely(!ashmem_area_cachep)) {
- printk(KERN_ERR "ashmem: failed to create slab cache\n");
+ pr_err("ashmem: failed to create slab cache\n");
return -ENOMEM;
}
@@ -715,19 +715,19 @@ static int __init ashmem_init(void)
sizeof(struct ashmem_range),
0, 0, NULL);
if (unlikely(!ashmem_range_cachep)) {
- printk(KERN_ERR "ashmem: failed to create slab cache\n");
+ pr_err("ashmem: failed to create slab cache\n");
return -ENOMEM;
}
ret = misc_register(&ashmem_misc);
if (unlikely(ret)) {
- printk(KERN_ERR "ashmem: failed to register misc device!\n");
+ pr_err("ashmem: failed to register misc device!\n");
return ret;
}
register_shrinker(&ashmem_shrinker);
- printk(KERN_INFO "ashmem: initialized\n");
+ pr_info("ashmem: initialized\n");
return 0;
}
@@ -740,12 +740,12 @@ static void __exit ashmem_exit(void)
ret = misc_deregister(&ashmem_misc);
if (unlikely(ret))
- printk(KERN_ERR "ashmem: failed to unregister misc device!\n");
+ pr_err("ashmem: failed to unregister misc device!\n");
kmem_cache_destroy(ashmem_range_cachep);
kmem_cache_destroy(ashmem_area_cachep);
- printk(KERN_INFO "ashmem: unloaded\n");
+ pr_info("ashmem: unloaded\n");
}
module_init(ashmem_init);
--
1.7.7.6
next reply other threads:[~2012-06-29 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 16:27 Pablo Vazquez Rodriguez [this message]
2012-06-29 16:37 ` [PATCH] Staging: android: fix pr_info and pr_err coding style issues in ashmem.c Joe Perches
[not found] ` <CAJ6TP82bM4d+pAc-+w_Y934FgBz5sQoyHm118s39GH5tf3TkJA@mail.gmail.com>
2012-07-06 23:16 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2012-07-07 1:06 Pablo Vazquez Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340987232-25169-1-git-send-email-peibolvigo@gmail.com \
--to=peibolvigo@gmail.com \
--cc=arve@android.com \
--cc=bringert@android.com \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox