From: "Steven J. Magnani" <steve@digidescorp.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: Refactor shortname parsing
Date: Fri, 29 Jun 2012 14:13:55 -0500 [thread overview]
Message-ID: <1340997235.9826.7.camel@iscandar.digidescorp.com> (raw)
In-Reply-To: <87r4syrl4y.fsf@devron.myhome.or.jp>
On Sat, 2012-06-30 at 04:08 +0900, OGAWA Hirofumi wrote:
> "Steven J. Magnani" <steve@digidescorp.com> writes:
>
> > Nearly identical shortname parsing is performed in fat_search_long()
> > and __fat_readdir(). Extract this code into a function that may be
> > called by both.
>
> What is the difference, and why changes was needed?
The only difference I could see was in the "dot_hidden" functionality.
fat_search_long() never does it; __fat_readdir() does it only when the
'dotsOK' option is active.
The changes are not 'needed'; they are purely to simplify future
maintenance of the code.
Regards,
Steve
next prev parent reply other threads:[~2012-06-29 19:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 18:12 [PATCH] fat: Refactor shortname parsing Steven J. Magnani
2012-06-29 19:08 ` OGAWA Hirofumi
2012-06-29 19:13 ` Steven J. Magnani [this message]
2012-06-29 20:03 ` OGAWA Hirofumi
2012-06-29 20:09 ` OGAWA Hirofumi
2012-07-02 13:01 ` Steven J. Magnani
2012-07-02 13:40 ` OGAWA Hirofumi
2012-07-02 14:00 ` Steven J. Magnani
2012-07-02 14:36 ` OGAWA Hirofumi
2012-07-02 14:45 ` Steven J. Magnani
2012-07-02 15:11 ` OGAWA Hirofumi
2012-07-02 15:51 ` Steven J. Magnani
2012-07-02 16:59 ` OGAWA Hirofumi
-- strict thread matches above, loose matches on Subject: below --
2012-07-03 11:14 Steven J. Magnani
2012-07-03 11:28 ` OGAWA Hirofumi
2012-08-03 14:52 ` Jan Engelhardt
2012-08-03 15:06 ` OGAWA Hirofumi
2012-08-03 15:58 ` Jan Engelhardt
2012-08-03 16:09 ` Steven J. Magnani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340997235.9826.7.camel@iscandar.digidescorp.com \
--to=steve@digidescorp.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox