linux-next: build warnings after merge of the libata tree

linux-next: build warnings after merge of the libata tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1882 bytes --]

Hi Jeff,

After merging the libata tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warnings:

drivers/ata/libata.h:134:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:135:13: warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
drivers/ata/libata.h:136:13: warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:135:13: warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
drivers/ata/libata.h:136:13: warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
drivers/ata/libata.h:135:13: warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
drivers/ata/libata.h:136:13: warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:135:13: warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
drivers/ata/libata.h:136:13: warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
drivers/ata/libata.h:134:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
drivers/ata/libata.h:135:13: warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
drivers/ata/libata.h:136:13: warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]

Introduced by commits 6b66d95895c1 ("libata: bind the Linux device tree
to the ACPI device tree") and 3bd46600a7a7 ("libata-acpi: add ata port
runtime D3Cold support").  Several "inline"s missing ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warnings after merge of the libata tree

[Lin Ming]

On Mon, 2012-07-02 at 13:19 +1000, Stephen Rothwell wrote:
> Hi Jeff,
> 
> After merging the libata tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
> 
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:135:13: warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
> drivers/ata/libata.h:136:13: warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:135:13: warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
> drivers/ata/libata.h:136:13: warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
> drivers/ata/libata.h:135:13: warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
> drivers/ata/libata.h:136:13: warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:135:13: warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
> drivers/ata/libata.h:136:13: warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
> drivers/ata/libata.h:134:13: warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
> drivers/ata/libata.h:135:13: warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
> drivers/ata/libata.h:136:13: warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]
> 
> Introduced by commits 6b66d95895c1 ("libata: bind the Linux device tree
> to the ACPI device tree") and 3bd46600a7a7 ("libata-acpi: add ata port
> runtime D3Cold support").  Several "inline"s missing ...
> 

Hi Stephen,

Could you please send me your ppc64 .config?
I'll do cross build on my x86 machine.

Thanks,
Lin Ming

Re: linux-next: build warnings after merge of the libata tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hi Lin,

On Mon, 02 Jul 2012 11:21:58 +0800 Lin Ming <ming.m.lin@intel.com> wrote:
>
> Could you please send me your ppc64 .config?
> I'll do cross build on my x86 machine.

Please just look at the code added in drivers/ata/libata.h.  Hint: what
happens if CONFIG_ATA_ACPI is *not* defined?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warnings after merge of the libata tree

[Lin Ming]

On Mon, 2012-07-02 at 13:54 +1000, Stephen Rothwell wrote:
> Hi Lin,
> 
> On Mon, 02 Jul 2012 11:21:58 +0800 Lin Ming <ming.m.lin@intel.com> wrote:
> >
> > Could you please send me your ppc64 .config?
> > I'll do cross build on my x86 machine.
> 
> Please just look at the code added in drivers/ata/libata.h.  Hint: what
> happens if CONFIG_ATA_ACPI is *not* defined?
> 

Hi Stephen,

Could you pick below fix?
Thanks.

>From cc270d0b3b132a37290db5fe3941361243540a18 Mon Sep 17 00:00:00 2001
From: Lin Ming <ming.m.lin@intel.com>
Date: Mon, 2 Jul 2012 12:20:39 +0800
Subject: [PATCH] libata-acpi: add missing inlines in libata.h

Adds inline for ata_acpi_unregister/ata_acpi_bind/ata_acpi_unbind
in drivers/ata/libata.h for !CONFIG_ATA_ACPI to fix below warnings.

warning: 'ata_acpi_unregister' defined but not used [-Wunused-function]
warning: 'ata_acpi_bind' defined but not used [-Wunused-function]
warning: 'ata_acpi_unbind' defined but not used [-Wunused-function]

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
 drivers/ata/libata.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
index 44a7939..50e4dff 100644
--- a/drivers/ata/libata.h
+++ b/drivers/ata/libata.h
@@ -131,9 +131,9 @@ static inline void ata_acpi_on_disable(struct ata_device *dev) { }
 static inline void ata_acpi_set_state(struct ata_port *ap,
 				      pm_message_t state) { }
 static inline int ata_acpi_register(void) { return 0; }
-static void ata_acpi_unregister(void) { }
-static void ata_acpi_bind(struct ata_device *dev) { }
-static void ata_acpi_unbind(struct ata_device *dev) { }
+static inline void ata_acpi_unregister(void) { }
+static inline void ata_acpi_bind(struct ata_device *dev) { }
+static inline void ata_acpi_unbind(struct ata_device *dev) { }
 #endif
 
 /* libata-scsi.c */
-- 
1.7.2.5

Re: linux-next: build warnings after merge of the libata tree

[Jeff Garzik]

On 07/02/2012 12:31 AM, Lin Ming wrote:
> diff --git a/drivers/ata/libata.h b/drivers/ata/libata.h
> index 44a7939..50e4dff 100644
> --- a/drivers/ata/libata.h
> +++ b/drivers/ata/libata.h
> @@ -131,9 +131,9 @@ static inline void ata_acpi_on_disable(struct ata_device *dev) { }
>   static inline void ata_acpi_set_state(struct ata_port *ap,
>   				      pm_message_t state) { }
>   static inline int ata_acpi_register(void) { return 0; }
> -static void ata_acpi_unregister(void) { }
> -static void ata_acpi_bind(struct ata_device *dev) { }
> -static void ata_acpi_unbind(struct ata_device *dev) { }
> +static inline void ata_acpi_unregister(void) { }
> +static inline void ata_acpi_bind(struct ata_device *dev) { }
> +static inline void ata_acpi_unbind(struct ata_device *dev) { }

applied (and #NEXT updated, of course)

linux-next: build warnings after merge of the libata tree

[Stephen Rothwell]

Hi Tejun,

After merging the libata tree, today's linux-next build (arm
multi_v7_defconfig) produced these warning:

drivers/ata/libata-scsi.c: In function 'ata_mselect_caching':
drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
    if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
                            ^
drivers/ata/libata-scsi.c: In function 'ata_mselect_control':
drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
    if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
                            ^

Introduced by commit

  9b7844a8c34a ("libata-scsi: fix read-only bits checking in ata_mselect_*()")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the libata tree

[Tejun Heo]

Hello, Stephen.

On Thu, Jul 21, 2016 at 03:26:03PM +1000, Stephen Rothwell wrote:
> Hi Tejun,
> 
> After merging the libata tree, today's linux-next build (arm
> multi_v7_defconfig) produced these warning:
> 
> drivers/ata/libata-scsi.c: In function 'ata_mselect_caching':
> drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
>     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
>                             ^
> drivers/ata/libata-scsi.c: In function 'ata_mselect_control':
> drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
>     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
>                             ^
> 
> Introduced by commit
> 
>   9b7844a8c34a ("libata-scsi: fix read-only bits checking in ata_mselect_*()")

Already reverted the patch.  Sorry about that.

Thanks.

-- 
tejun

Re: linux-next: build warnings after merge of the libata tree

[Stephen Rothwell]

Hi Tejun,

On Thu, 21 Jul 2016 10:44:59 -0400 Tejun Heo <tj@kernel.org> wrote:
>
> On Thu, Jul 21, 2016 at 03:26:03PM +1000, Stephen Rothwell wrote:
> > Hi Tejun,
> > 
> > After merging the libata tree, today's linux-next build (arm
> > multi_v7_defconfig) produced these warning:
> > 
> > drivers/ata/libata-scsi.c: In function 'ata_mselect_caching':
> > drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
> >     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
> >                             ^
> > drivers/ata/libata-scsi.c: In function 'ata_mselect_control':
> > drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
> >     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
> >                             ^
> > 
> > Introduced by commit
> > 
> >   9b7844a8c34a ("libata-scsi: fix read-only bits checking in ata_mselect_*()")  
> 
> Already reverted the patch.  Sorry about that.

This patch is still in the libata tree
(git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git#for-next)
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warnings after merge of the libata tree

[Tejun Heo]

On Wed, Jul 27, 2016 at 04:32:31PM +1000, Stephen Rothwell wrote:
> This patch is still in the libata tree
> (git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata.git#for-next)

Oops, forgot to revert for-next.  Fixed up now.

Thanks.

-- 
tejun