public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Steven J. Magnani" <steve@digidescorp.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: Refactor shortname parsing
Date: Mon, 02 Jul 2012 08:01:39 -0500	[thread overview]
Message-ID: <1341234099.1695.13.camel@iscandar.digidescorp.com> (raw)
In-Reply-To: <87zk7lribe.fsf@devron.myhome.or.jp>

On Sat, 2012-06-30 at 05:09 +0900, OGAWA Hirofumi wrote: 
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> 
> >
> > 			if (is_vfat)
> > 				ptname[i++] = fat_tolower(!nocase, c);
> 
> Of course, if (!is_vfat). Sorry.

I agree that the nocase logic is confusing, but I'm pretty sure this
change would break the code. 

'nocase' is always zero for vfat, which does not recognize that option.
For msdos, it is zero by default, and 1 if the 'nocase' option was
specified.
In all cases it is necessary to copy *something* to ptname.

What could be done is something like this:

if (nocase)
ptname[i++] = c;
else
ptname[i++] = fat_tolower(c);

or, if you don't mind trigraphs:
ptname[i++] = nocase ? c : fat_tolower(c);

Let me know what you prefer.

Thanks,
Steve



  reply	other threads:[~2012-07-02 13:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 18:12 [PATCH] fat: Refactor shortname parsing Steven J. Magnani
2012-06-29 19:08 ` OGAWA Hirofumi
2012-06-29 19:13   ` Steven J. Magnani
2012-06-29 20:03     ` OGAWA Hirofumi
2012-06-29 20:09       ` OGAWA Hirofumi
2012-07-02 13:01         ` Steven J. Magnani [this message]
2012-07-02 13:40           ` OGAWA Hirofumi
2012-07-02 14:00             ` Steven J. Magnani
2012-07-02 14:36               ` OGAWA Hirofumi
2012-07-02 14:45                 ` Steven J. Magnani
2012-07-02 15:11                   ` OGAWA Hirofumi
2012-07-02 15:51                     ` Steven J. Magnani
2012-07-02 16:59                       ` OGAWA Hirofumi
  -- strict thread matches above, loose matches on Subject: below --
2012-07-03 11:14 Steven J. Magnani
2012-07-03 11:28 ` OGAWA Hirofumi
2012-08-03 14:52 ` Jan Engelhardt
2012-08-03 15:06   ` OGAWA Hirofumi
2012-08-03 15:58     ` Jan Engelhardt
2012-08-03 16:09       ` Steven J. Magnani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1341234099.1695.13.camel@iscandar.digidescorp.com \
    --to=steve@digidescorp.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox