From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933309Ab2GCDBd (ORCPT ); Mon, 2 Jul 2012 23:01:33 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:33632 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932139Ab2GCDBc (ORCPT ); Mon, 2 Jul 2012 23:01:32 -0400 Message-ID: <1341284473.18757.2.camel@phoenix> Subject: [PATCH 1/2] regulator: ad5398: Fix min/max current limit boundary checking From: Axel Lin To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, Sonic Zhang , Lars-Peter Clausen Date: Tue, 03 Jul 2012 11:01:13 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is ok to request current limit with min_uA < chip->min_uA and max_uA > chip->max_uA. Signed-off-by: Axel Lin --- drivers/regulator/ad5398.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c index 46d05f3..6a357dc 100644 --- a/drivers/regulator/ad5398.c +++ b/drivers/regulator/ad5398.c @@ -89,9 +89,7 @@ static int ad5398_set_current_limit(struct regulator_dev *rdev, int min_uA, int unsigned short data; int ret; - if (min_uA > chip->max_uA || min_uA < chip->min_uA) - return -EINVAL; - if (max_uA > chip->max_uA || max_uA < chip->min_uA) + if (min_uA > chip->max_uA || max_uA < chip->min_uA) return -EINVAL; selector = DIV_ROUND_UP((min_uA - chip->min_uA) * chip->current_level, -- 1.7.9.5