* [PATCH] drm/mgag200: fix null pointer dereference
@ 2012-07-07 9:22 Devendra Naga
0 siblings, 0 replies; only message in thread
From: Devendra Naga @ 2012-07-07 9:22 UTC (permalink / raw)
To: David Airlie, Dave Airlie, dri-devel, linux-kernel; +Cc: Devendra Naga
we are referencing the pointer after doing alloc_apertures,
as alloc_apertures kzallocs, the kzalloc may fail and we get a NULL.
so we need to check for NULL before we dereference this pointer
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index 93e832d..ea1024d 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -47,6 +47,9 @@ static void mgag200_kick_out_firmware_fb(struct pci_dev *pdev)
bool primary = false;
ap = alloc_apertures(1);
+ if (!ap)
+ return;
+
ap->ranges[0].base = pci_resource_start(pdev, 0);
ap->ranges[0].size = pci_resource_len(pdev, 0);
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-07 9:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-07 9:22 [PATCH] drm/mgag200: fix null pointer dereference Devendra Naga
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox