From: Joe Perches <joe@perches.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Marcos Paulo de Souza <marcos.mage@gmail.com>,
Forest Bond <forest@alittletooquiet.net>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: vt6656: iwctl: remove a few remaining redundant newlines
Date: Sun, 08 Jul 2012 16:05:40 -0700 [thread overview]
Message-ID: <1341788740.13174.33.camel@joe2Laptop> (raw)
In-Reply-To: <alpine.LNX.2.00.1207090056180.15263@swampdragon.chaosbits.net>
On Mon, 2012-07-09 at 00:59 +0200, Jesper Juhl wrote:
> I missed a few redundant newlines the first time.
[]
> diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
[]
> @@ -964,7 +964,6 @@ int iwctl_giwrts(struct net_device *dev, struct iw_request_info *info,
> wrq->value = pDevice->wRTSThreshold;
> wrq->disabled = (wrq->value >= 2312);
> wrq->fixed = 1;
> -
> return 0;
> }
I think this is a useful style and these should not be removed.
It's akin to a blank line after automatic variable declarations.
next prev parent reply other threads:[~2012-07-08 23:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 19:19 [PATCH] staging: vt6656: iwctl: mop up a few remaining obvious style issues Jesper Juhl
2012-07-06 23:09 ` Greg Kroah-Hartman
2012-07-07 0:29 ` Jesper Juhl
2012-07-08 22:58 ` [PATCH 0/3][v2] " Jesper Juhl
2012-07-08 22:58 ` [PATCH 1/3] staging: vt6656: iwctl: fix up spacing around operators Jesper Juhl
2012-07-08 23:03 ` Joe Perches
2012-07-08 23:19 ` Jesper Juhl
2012-07-08 22:58 ` [PATCH 2/3] staging: vt6656: iwctl: Fix up a few remaining brace issues Jesper Juhl
2012-07-08 22:59 ` [PATCH 3/3] staging: vt6656: iwctl: remove a few remaining redundant newlines Jesper Juhl
2012-07-08 23:05 ` Joe Perches [this message]
2012-07-08 23:16 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341788740.13174.33.camel@joe2Laptop \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.mage@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox