From: Li Zhong <zhong@linux.vnet.ibm.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
arjan@linux.intel.com,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] Fix a dead loop in async_synchronize_full()
Date: Mon, 09 Jul 2012 09:33:30 +0800 [thread overview]
Message-ID: <1341797610.2439.3.camel@ThinkPad-T420> (raw)
In-Reply-To: <CAM_iQpXhgqOQcD1s9O2weQv8xqfZ6Jpc4atR+QSosrYocbCK-Q@mail.gmail.com>
On Fri, 2012-07-06 at 17:12 +0800, Cong Wang wrote:
> On Mon, Jul 2, 2012 at 2:04 PM, Li Zhong <zhong@linux.vnet.ibm.com> wrote:
> > void async_synchronize_full(void)
> > {
> > - do {
> > - async_synchronize_cookie(next_cookie);
> > - } while (!list_empty(&async_running) || !list_empty(&async_pending));
> > + async_synchronize_cookie_domain(next_cookie, NULL);
> > }
>
> A nitpick:
>
> async_synchronize_cookie_domain(next_cookie, NULL);
>
> equals to
>
> async_synchronize_full_domain(NULL)
>
Why do we need one more level in the function calling stack?
prev parent reply other threads:[~2012-07-09 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 6:04 [PATCH] Fix a dead loop in async_synchronize_full() Li Zhong
2012-07-06 3:51 ` Christian Kujau
2012-07-09 1:30 ` Li Zhong
2012-07-06 9:12 ` Cong Wang
2012-07-09 1:33 ` Li Zhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341797610.2439.3.camel@ThinkPad-T420 \
--to=zhong@linux.vnet.ibm.com \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox