From: Joe Perches <joe@perches.com>
To: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Cc: gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
jj@chaosbits.net, forest@alittletooquiet.net,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] staging: vt6655: Cleanup in usage of macros
Date: Sun, 08 Jul 2012 21:24:51 -0700 [thread overview]
Message-ID: <1341807891.13174.40.camel@joe2Laptop> (raw)
In-Reply-To: <1341802286-28281-1-git-send-email-marcos.souza.org@gmail.com>
On Sun, 2012-07-08 at 23:51 -0300, Marcos Paulo de Souza wrote:
> Hi kernel guys!
>
> This patchset aims to clean all unused and commented macros.
>
> For this challenge, forgotten-macros tool helped us.
Perhaps there may be false positives in your code.
Many times, macros like the below are used:
#define SUBSYSTEM_PREFIX_FOO 1
#define SUBSYSTEM_PREFIX_BAR 2
#define SUBSYSTEM_PREFIX_BAZ 3
#define USE_TYPE(type) SUBSYSTEM_PREFIX_##type
It doesn't seem your code knows that style.
Also, the tool might be more flexible if it was
written using perl or python.
next prev parent reply other threads:[~2012-07-09 4:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 2:51 [PATCH 0/6] staging: vt6655: Cleanup in usage of macros Marcos Paulo de Souza
2012-07-09 2:51 ` [PATCH 1/6] staging: vt6655: Remove all "if 0" blocks from driver Marcos Paulo de Souza
2012-07-09 2:51 ` [PATCH 2/6] staging: vt6655: mac.h: Remove all commented macros Marcos Paulo de Souza
2012-07-09 2:51 ` [PATCH 3/6] staging: vt6655: rf.c: Remove all unused macros Marcos Paulo de Souza
2012-07-09 2:51 ` [PATCH 4/6] staging: vt6655: baseband.h: " Marcos Paulo de Souza
2012-07-09 2:51 ` [PATCH 5/6] staging: vt6655: Remove all commented macros Marcos Paulo de Souza
2012-07-09 2:51 ` [PATCH 6/6] staging: vt6655: hostap.c: Remove all unused macros Marcos Paulo de Souza
2012-07-09 4:24 ` Joe Perches [this message]
2012-07-09 9:19 ` [PATCH 0/6] staging: vt6655: Cleanup in usage of macros Marcos Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341807891.13174.40.camel@joe2Laptop \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox