[PATCH] sched: Use task_rq_unlock on __sched_setscheduler

[PATCH] sched: Use task_rq_unlock on __sched_setscheduler

[Namhyung Kim]

From: Namhyung Kim <namhyung.kim@lge.com>

It seems there's no specific reason to open-code it.  I guess the
commit 0122ec5b02f76 ("sched: Add p->pi_lock to task_rq_lock()")
simply missed it.  Let's be consistent with others.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 kernel/sched/core.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 3987b9ddc563..1327f4de2054 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4343,9 +4343,7 @@ recheck:
 	 */
 	if (unlikely(policy == p->policy && (!rt_policy(policy) ||
 			param->sched_priority == p->rt_priority))) {
-
-		__task_rq_unlock(rq);
-		raw_spin_unlock_irqrestore(&p->pi_lock, flags);
+		task_rq_unlock(rq, p, &flags);
 		return 0;
 	}
 
-- 
1.7.10.4

Re: [PATCH] sched: Use task_rq_unlock on __sched_setscheduler

[Peter Zijlstra]

On Sat, 2012-07-07 at 16:49 +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
> 
> It seems there's no specific reason to open-code it.  I guess the
> commit 0122ec5b02f76 ("sched: Add p->pi_lock to task_rq_lock()")
> simply missed it.  Let's be consistent with others.

Looks that way, thanks!

[tip:sched/urgent] sched: Use task_rq_unlock() in __sched_setscheduler()

[tip-bot for Namhyung Kim]

Commit-ID:  45afb1734fa6323a8ba08bd6c392ee227df67dde
Gitweb:     http://git.kernel.org/tip/45afb1734fa6323a8ba08bd6c392ee227df67dde
Author:     Namhyung Kim <namhyung.kim@lge.com>
AuthorDate: Sat, 7 Jul 2012 16:49:02 +0900
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 26 Jul 2012 11:46:59 +0200

sched: Use task_rq_unlock() in __sched_setscheduler()

It seems there's no specific reason to open-code it.  I guess
commit 0122ec5b02f76 ("sched: Add p->pi_lock to task_rq_lock()")
simply missed it.  Let's be consistent with others.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1341647342-6742-1-git-send-email-namhyung@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/core.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 5d011ef..2cb4e77 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4340,9 +4340,7 @@ recheck:
 	 */
 	if (unlikely(policy == p->policy && (!rt_policy(policy) ||
 			param->sched_priority == p->rt_priority))) {
-
-		__task_rq_unlock(rq);
-		raw_spin_unlock_irqrestore(&p->pi_lock, flags);
+		task_rq_unlock(rq, p, &flags);
 		return 0;
 	}